Closed Bug 1121248 Opened 6 years ago Closed 6 years ago

Stop logging unimplemented SourceBufferResource methods with NSPR_LOG_MODULES=MediaSource:5

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: bholley, Assigned: bholley)

Details

Attachments

(1 file)

This is super spammy, and makes the logs 10x larger than they need to be.
Attachment #8548513 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/27179504118c

This will make NSPR logs generated with MediaSource:5 by QA etc 10x smaller, so we might as well uplift it.
Flags: needinfo?(giles)
Comment on attachment 8548513 [details] [diff] [review]
Stop logging unimplemented methods in SourceBufferResource. v1

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TBPL]: presuming green on inbound.
[Risks and why]: Minimal. Debug logging change only.
[String/UUID change made/needed]: None.
Flags: needinfo?(giles)
Attachment #8548513 - Flags: approval-mozilla-beta?
Attachment #8548513 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/27179504118c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attachment #8548513 - Flags: approval-mozilla-beta?
Attachment #8548513 - Flags: approval-mozilla-beta+
Attachment #8548513 - Flags: approval-mozilla-aurora?
Attachment #8548513 - Flags: approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.