Closed
Bug 1121248
Opened 10 years ago
Closed 10 years ago
Stop logging unimplemented SourceBufferResource methods with NSPR_LOG_MODULES=MediaSource:5
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: bholley, Assigned: bholley)
Details
Attachments
(1 file)
914 bytes,
patch
|
mattwoodrow
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This is super spammy, and makes the logs 10x larger than they need to be.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8548513 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8548513 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/27179504118c
This will make NSPR logs generated with MediaSource:5 by QA etc 10x smaller, so we might as well uplift it.
Flags: needinfo?(giles)
Comment 3•10 years ago
|
||
Comment on attachment 8548513 [details] [diff] [review]
Stop logging unimplemented methods in SourceBufferResource. v1
Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TBPL]: presuming green on inbound.
[Risks and why]: Minimal. Debug logging change only.
[String/UUID change made/needed]: None.
Flags: needinfo?(giles)
Attachment #8548513 -
Flags: approval-mozilla-beta?
Attachment #8548513 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8548513 -
Flags: approval-mozilla-beta?
Attachment #8548513 -
Flags: approval-mozilla-beta+
Attachment #8548513 -
Flags: approval-mozilla-aurora?
Attachment #8548513 -
Flags: approval-mozilla-aurora+
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•