Remove commented-out "OuterFrame::Reflow" printfs from nsSubDocumentFrame::Reflow (from 1998)

RESOLVED FIXED in mozilla38

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla38
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

nsSubDocumentFrame has some commented-out "OuterFrame::Reflow" printf's, which have been there (and have been commented out) since as far back as I can dig -- 1998 -- in http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsFrameFrame.cpp&rev=3.1&root=/cvsroot

Nowadays, the class isn't named anything like "OuterFrame" anymore, and we strongly discourage dead code, so we should just remove these lines. People can add their own printfs locally if they like.

(Note: this code doesn't even compile if I uncomment it, at least with --enable-warnings-as-errors in my .mozconfig, because "%X" is the wrong format string for the pointer value "this".)
Landed patch to remove these lines:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07029b5f00e9
Assignee: nobody → dholbert
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/07029b5f00e9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.