Remove PLDHashTableOps::{alloc,free}Table

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla38
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

PLDHashTableOps::{alloc,free}Table are never set to anything other than PL_DHash{Alloc,Free}Table. Let's get rid of them.

The patches I'm about to post apply on top of the patches in bug 1120476.
Attachment #8548605 - Flags: review?(nfroyd)
Attachment #8548606 - Flags: review?(nfroyd)
Attachment #8548605 - Attachment is obsolete: true
Attachment #8548605 - Flags: review?(nfroyd)
Attachment #8548610 - Flags: review?(nfroyd)
Attachment #8548606 - Attachment is obsolete: true
Attachment #8548606 - Flags: review?(nfroyd)
Attachment #8548610 - Attachment is obsolete: true
Attachment #8548610 - Flags: review?(nfroyd)
Excuse me! |hg bzexport| is being difficult.
Attachment #8548615 - Flags: review?(nfroyd) → review+
Comment on attachment 8548617 [details] [diff] [review]
(part 2) - Remove PLDHashTableOps::{alloc,free}Table

Review of attachment 8548617 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for boilerplate removal.
Attachment #8548617 - Flags: review?(nfroyd) → review+
Blocks: 1121488
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d561a7fc7b74

reftest-8 on b2g is a joke, and not a good one, because it hangs all the time in some random subtest of webgl-color-test.html (see https://bugzilla.mozilla.org/buglist.cgi?quicksearch=webgl-color-test.html though there are a lot more, we just don't bother filing new ones anymore). However, you made it consistent, always hanging in the first one, webgl-color-test.html?frame=1&__&preserve&premult&_____
(In reply to Phil Ringnalda (:philor) from comment #9)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d561a7fc7b74
> 
> reftest-8 on b2g is a joke, and not a good one, because it hangs all the
> time in some random subtest of webgl-color-test.html (see
> https://bugzilla.mozilla.org/buglist.cgi?quicksearch=webgl-color-test.html
> though there are a lot more, we just don't bother filing new ones anymore).
> However, you made it consistent, always hanging in the first one,
> webgl-color-test.html?frame=1&__&preserve&premult&_____

I just did three try runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=52c5ad8c9622
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70d3559846db
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe96a38cb20f

The first run was the trunk, the second run had my first patch, and the third run had my second patch as well. In all three runs I triggered the B2G R8 test 10 times. On the first run it failed twice, on the second four times, and on the third twice.

With that in mind I posit that yesterday's permafails were an unlucky fluke that weren't intrinsically related to my patches. This makes sense to me because both patches were borderline-trivial refactorings that shouldn't have any effect on these tests.

Therefore, I will reland the patches as-is.
https://hg.mozilla.org/mozilla-central/rev/a4f38467bc4e
https://hg.mozilla.org/mozilla-central/rev/20544516f48d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.