[Bluetooth][API v2] There is no device name from 'onpairingconfirmationreq' event.

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: iliu@mozilla.com, ianliu.moz@gmail.com, Assigned: btian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [webbt-api])

Attachments

(1 attachment, 1 obsolete attachment)

Since implementation of pairing process via WIP of bug 1119734, I meet a bug about no device name from the 'onpairingconfirmationreq' event.
======== Log ==========

I/Jamin   (17456): BluetoothPairingListener::DispatchPairingEvent
I/Jamin   (17456): after sleep BluetoothPairingListener::Run
I/Bluetooth Manager(17456): Content JS LOG: --> evt = [object BluetoothPairingEvent] 
I/Bluetooth Manager(17456):     at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:133:6)
I/Bluetooth Manager(17456): Content JS LOG: --> evt.device = [object BluetoothDevice] 
I/Bluetooth Manager(17456):     at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:134:6)
I/Bluetooth Manager(17456): Content JS LOG: --> evt.device.name =  
I/Bluetooth Manager(17456):     at PairManager._onPairingConfirmationReq (app://bluetooth.gaiamobile.org/js/pair_manager_v2.js:135:6)
(Assignee)

Updated

3 years ago
Whiteboard: [webbt-api]
(Assignee)

Comment 2

3 years ago
Created attachment 8549398 [details] [diff] [review]
Patch 1 (v1): Append device name to BluetoothDevice in BluetoothPairingEvent

Note this bug was affected by bug 1100818.
Assignee: jaliu → btian
Status: NEW → ASSIGNED
Attachment #8549398 - Flags: review?(shuang)
Attachment #8549398 - Flags: feedback?(jaliu)
Comment on attachment 8549398 [details] [diff] [review]
Patch 1 (v1): Append device name to BluetoothDevice in BluetoothPairingEvent

Review of attachment 8549398 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me.

::: dom/bluetooth2/BluetoothPairingListener.cpp
@@ +105,5 @@
>  
> +    /**
> +     * Create a temporary device with deviceAddress and deviceName
> +     *
> +     * FIXME: Replace BluetoothDevice in BluetootPairingEvent with device

I prefer to remove FIXME and open an another bug for tracking this.
Attachment #8549398 - Flags: review?(shuang) → review+
Comment on attachment 8549398 [details] [diff] [review]
Patch 1 (v1): Append device name to BluetoothDevice in BluetoothPairingEvent

Looks good to me. :)
Attachment #8549398 - Flags: feedback?(jaliu) → feedback+
(Assignee)

Comment 5

3 years ago
Created attachment 8550033 [details] [diff] [review]
Patch 1 (v2): Append device name to BluetoothDevice in BluetoothPairingEvent, r=shuang, f=jaliu

Remove comment addressed in comment 3 since the change involves API revision. I'll discuss with gaia dev to decide whether to revise API later.
Attachment #8549398 - Attachment is obsolete: true
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/85c5c57b50dd

No try since the affected folder (dom/bluetooth2) is not built by default.
https://hg.mozilla.org/mozilla-central/rev/85c5c57b50dd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.