Closed Bug 1121343 Opened 7 years ago Closed 7 years ago

[FTE] Notification indicator shows during FTE, but un-actionable

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 affected, b2g-master verified)

VERIFIED FIXED
2.2 S6 (20feb)
Tracking Status
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: mikehenrty, Assigned: mancas)

Details

(Keywords: verifyme, Whiteboard: [systemsfe])

Attachments

(2 files)

STR:

1.) Add voicemail to SIM card.
2.) Flash phone with FTE enabled.

Expected result:
Either ambient indicator for voicemail notifications doesn't show.

Actual result:
Ambient indicator shows, but is un-actionable (ie. you cannot drag down the utility tray).
Confusing UX.
blocking-b2g: --- → 2.2?
Assignee: nobody → b.mcb
Attached file Proposed patch
Etienne, could you review this, please? I've modified the notifications to avoid show the ambient indicator if the FTU is running, because during the FTU, the statusbar is not available.

Also, set feedback flag to Fernando in order to know if this is the expected behaviour in the app.
Attachment #8549531 - Flags: review?(etienne)
Attachment #8549531 - Flags: feedback?(fernando.campo)
Edge case
blocking-b2g: 2.2? → ---
Comment on attachment 8549531 [details] [review]
Proposed patch

The change makes sense to me, we should probably still get UX to confirm.

Made a small comment on github + we'll need a test.

Cheers!
Attachment #8549531 - Flags: review?(etienne)
Comment on attachment 8549531 [details] [review]
Proposed patch

Yes I agree is the best option.

If user can't do anything about it, better to hide it (as long as it's visible again after finishing the FTE).
Attachment #8549531 - Flags: feedback?(fernando.campo) → feedback+
Comment on attachment 8549531 [details] [review]
Proposed patch

Hey Etienne, I've added the unit tests, could you check it?

Thanks =)
Attachment #8549531 - Flags: review?(etienne)
Comment on attachment 8549531 [details] [review]
Proposed patch

r=me with a small nit
Attachment #8549531 - Flags: review?(etienne) → review+
Francis, could you tell us what is the expected behaviour in this case? Please, take into account that the user can't open the utility tray to see the notifications during the FTU.

Thanks!
Flags: needinfo?(fdjabri)
Rob, could you take a look at this as it relates to Notifications?
Flags: needinfo?(fdjabri) → needinfo?(rmacdonald)
Hiding the ambient indicator while the FTU is running is the expected behaviour. Thanks for flagging us!
Flags: needinfo?(rmacdonald)
Manuel, let me know if you want me to land this patch.
Flags: needinfo?(b.mcb)
Let's wait for the green light in the tests. Thanks!
Flags: needinfo?(b.mcb)
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S6 (20feb)
This issue is verified fixed on Flame Master.

Result: The ambient indicator is not displayed during FTE. It appears on the homescreen when FTE is complete.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
======================

Leaving verifyme for 2.2 verification
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.