1121343 - [FTE] Notification indicator shows during FTE, but un-actionable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] ambient indicator on FTE

STR:

1.) Add voicemail to SIM card.
2.) Flash phone with FTE enabled.

Expected result:
Either ambient indicator for voicemail notifications doesn't show.

Actual result:
Ambient indicator shows, but is un-actionable (ie. you cannot drag down the utility tray).

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Confusing UX.

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Etienne, could you review this, please? I've modified the notifications to avoid show the ambient indicator if the FTU is running, because during the FTU, the statusbar is not available.

Also, set feedback flag to Fernando in order to know if this is the expected behaviour in the app.

Comment 3

[Gregor Wagner [:gwagner]]

Edge case

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8549531 [details] [review]
Proposed patch

The change makes sense to me, we should probably still get UX to confirm.

Made a small comment on github + we'll need a test.

Cheers!

Comment 5

[Fernando Campo (:fcampo)]

Comment on attachment 8549531 [details] [review]
Proposed patch

Yes I agree is the best option.

If user can't do anything about it, better to hide it (as long as it's visible again after finishing the FTE).

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8549531 [details] [review]
Proposed patch

Hey Etienne, I've added the unit tests, could you check it?

Thanks =)

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8549531 [details] [review]
Proposed patch

r=me with a small nit

Comment 8

[Manuel Casas Barrado [:mancas]]

Francis, could you tell us what is the expected behaviour in this case? Please, take into account that the user can't open the utility tray to see the notifications during the FTU.

Thanks!

Comment 9

[Francis Djabri [:djabber]]

Rob, could you take a look at this as it relates to Notifications?

Comment 10

[Rob MacDonald [:robmac]]

Hiding the ambient indicator while the FTU is running is the expected behaviour. Thanks for flagging us!

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Manuel, let me know if you want me to land this patch.

Comment 12

[Manuel Casas Barrado [:mancas]]

Let's wait for the green light in the tests. Thanks!

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/aa909eeee058d5754590a927c96566a61605e7c6

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: The ambient indicator is not displayed during FTE. It appears on the homescreen when FTE is complete.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
======================

Leaving verifyme for 2.2 verification