Closed Bug 1121398 Opened 6 years ago Closed 6 years ago

WIFI signal strength mismatch between status bar and settings app

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0M+, b2g-v2.0 affected, b2g-v2.0M fixed, b2g-v2.1 affected, b2g-v2.1S affected, b2g-v2.2 affected, b2g-v2.2r wontfix, b2g-master verified)

RESOLVED FIXED
blocking-b2g 2.0M+
Tracking Status
b2g-v2.0 --- affected
b2g-v2.0M --- fixed
b2g-v2.1 --- affected
b2g-v2.1S --- affected
b2g-v2.2 --- affected
b2g-v2.2r --- wontfix
b2g-master --- verified

People

(Reporter: yifan, Assigned: yifan)

References

Details

Attachments

(2 files)

The WIFI signal strength are displayed differently between the status bar and the settings app when a user connects to one of the wifi APs having the same SSID.
See Also: → 1117710
blocking-b2g: --- → 2.0M?
Status: NEW → ASSIGNED
Attached file pull request
In the settings app, the AP with the best signal strength among the APs with the same SSID wasn't picked when wifi_helper.js shortens the list of wifi APs.

The PR makes sure that the best signal strength one is displayed in the settings app.
Attachment #8549318 - Flags: review?(ejchen)
Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan, this patch looks okay to me, but I think we should add one more test case to make sure this works as what we expected and please help to add one more comment to make this code change more understandable.

Thanks !! YiFan+++
Attachment #8549318 - Flags: review?(ejchen)
Comment on attachment 8549318 [details] [review]
pull request

Thank you EJ! Added a code comment and test case.
Attachment #8549318 - Flags: ui-review?(ejchen)
Attachment #8549318 - Flags: ui-review?(ejchen) → review?(ejchen)
Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan !! r++
Attachment #8549318 - Flags: review?(ejchen) → review+
Blocks: Woodduck
blocking-b2g: 2.0M? → 2.0M+
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
See Also: → 1123262
Thank you!

Merged into master https://github.com/mozilla-b2g/gaia/pull/27400

Test completed https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=53bae60fdd35
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hi Kai-Zhen,
Could you please help to merge the patch to 2.0M? Thanks!
Flags: needinfo?(kli)
This issue has been verified as pass on latest build of flame master and nexus5 master.
Rate:0/5

Device: Flame master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.193055
Firmware Date          Sun Jul  5 19:31:07 EDT 2015
Bootloader             L1TC000118D0

Device: N5 master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150705.193225
Firmware Date          Sun Jul  5 19:32:44 EDT 2015
Bootloader             HHZ12f
QA Whiteboard: [MGSEI-Triage+]
ni Josh for suggestions on 2.1 & 2.2 approval.
Flags: needinfo?(jocheng)
Hi Vance,
Do we still need this for 2.1/2.1S?
Thanks!
Flags: needinfo?(jocheng) → needinfo?(vchen)
Hi Wesley,
Do you need this for feature phone on 2.2r?
Thanks
Flags: needinfo?(whuang)
2.2r is a derived branch from 2.2.
We supposedly only add feature phone relevant features and critical bug fixes.
Other than that I think should be the same as 2.2.
Flags: needinfo?(whuang)
No, 2.1/2.1s don't need it. However, I think since feature phone still will have wifi signal bar display on the screen, I would recommend to land this one on 2.2R

Thanks
Flags: needinfo?(vchen)
You need to log in before you can comment on or make changes to this bug.