WIFI signal strength mismatch between status bar and settings app

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: yifan, Assigned: yifan)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.0M+, b2g-v2.0 affected, b2g-v2.0M fixed, b2g-v2.1 affected, b2g-v2.1S affected, b2g-v2.2 affected, b2g-v2.2r wontfix, b2g-master verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
The WIFI signal strength are displayed differently between the status bar and the settings app when a user connects to one of the wifi APs having the same SSID.
(Assignee)

Updated

3 years ago
See Also: → bug 1117710
(Assignee)

Updated

3 years ago
blocking-b2g: --- → 2.0M?
status-b2g-v2.0: --- → affected
status-b2g-v2.0M: --- → affected
status-b2g-v2.1: --- → affected
status-b2g-v2.1S: --- → affected
status-b2g-v2.2: --- → affected
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8549318 [details] [review]
pull request

In the settings app, the AP with the best signal strength among the APs with the same SSID wasn't picked when wifi_helper.js shortens the list of wifi APs.

The PR makes sure that the best signal strength one is displayed in the settings app.
Attachment #8549318 - Flags: review?(ejchen)
Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan, this patch looks okay to me, but I think we should add one more test case to make sure this works as what we expected and please help to add one more comment to make this code change more understandable.

Thanks !! YiFan+++
Attachment #8549318 - Flags: review?(ejchen)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8549318 [details] [review]
pull request

Thank you EJ! Added a code comment and test case.
Attachment #8549318 - Flags: ui-review?(ejchen)
(Assignee)

Updated

3 years ago
Attachment #8549318 - Flags: ui-review?(ejchen) → review?(ejchen)
Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan !! r++
Attachment #8549318 - Flags: review?(ejchen) → review+

Updated

3 years ago
Blocks: 1054172, 1080481
blocking-b2g: 2.0M? → 2.0M+

Updated

3 years ago
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM

Updated

3 years ago
status-b2g-master: --- → affected

Updated

3 years ago
See Also: → bug 1123262
(Assignee)

Comment 5

3 years ago
Thank you!

Merged into master https://github.com/mozilla-b2g/gaia/pull/27400

Test completed https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=53bae60fdd35
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
status-b2g-master: affected → fixed

Comment 6

3 years ago
Hi Kai-Zhen,
Could you please help to merge the patch to 2.0M? Thanks!
Flags: needinfo?(kli)
v2.0m: https://github.com/mozilla-b2g/gaia/commit/e52a677fbced57c550879b7c8d43d81854919c0a
status-b2g-v2.0M: affected → fixed
Flags: needinfo?(kli)
Created attachment 8629825 [details]
Vmaster_Verify_screenshort.png

This issue has been verified as pass on latest build of flame master and nexus5 master.
Rate:0/5

Device: Flame master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.193055
Firmware Date          Sun Jul  5 19:31:07 EDT 2015
Bootloader             L1TC000118D0

Device: N5 master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150705.193225
Firmware Date          Sun Jul  5 19:32:44 EDT 2015
Bootloader             HHZ12f
status-b2g-master: fixed → verified
QA Whiteboard: [MGSEI-Triage+]
(Assignee)

Comment 10

3 years ago
ni Josh for suggestions on 2.1 & 2.2 approval.
Flags: needinfo?(jocheng)

Comment 11

3 years ago
Hi Vance,
Do we still need this for 2.1/2.1S?
Thanks!
Flags: needinfo?(jocheng) → needinfo?(vchen)

Comment 12

3 years ago
Hi Wesley,
Do you need this for feature phone on 2.2r?
Thanks
Flags: needinfo?(whuang)
2.2r is a derived branch from 2.2.
We supposedly only add feature phone relevant features and critical bug fixes.
Other than that I think should be the same as 2.2.
status-b2g-v2.2r: --- → wontfix
Flags: needinfo?(whuang)
No, 2.1/2.1s don't need it. However, I think since feature phone still will have wifi signal bar display on the screen, I would recommend to land this one on 2.2R

Thanks
Flags: needinfo?(vchen)
You need to log in before you can comment on or make changes to this bug.