1121398 - WIFI signal strength mismatch between status bar and settings app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[yifan [:yifan][:yliao]]

The WIFI signal strength are displayed differently between the status bar and the settings app when a user connects to one of the wifi APs having the same SSID.

Comment 1

[yifan [:yifan][:yliao]]

Attachment: pull request

In the settings app, the AP with the best signal strength among the APs with the same SSID wasn't picked when wifi_helper.js shortens the list of wifi APs.

The PR makes sure that the best signal strength one is displayed in the settings app.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan, this patch looks okay to me, but I think we should add one more test case to make sure this works as what we expected and please help to add one more comment to make this code change more understandable.

Thanks !! YiFan+++

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8549318 [details] [review]
pull request

Thank you EJ! Added a code comment and test case.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8549318 [details] [review]
pull request

Thanks YiFan !! r++

Comment 5

[yifan [:yifan][:yliao]]

Thank you!

Merged into master https://github.com/mozilla-b2g/gaia/pull/27400

Test completed https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=53bae60fdd35

Comment 6

[Josh Cheng [:josh]]

Hi Kai-Zhen,
Could you please help to merge the patch to 2.0M? Thanks!

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to yifan [:yifan][:yliao] from comment #5)
> Thank you!
> 
> Merged into master https://github.com/mozilla-b2g/gaia/pull/27400
> 

master: https://github.com/mozilla-b2g/gaia/commit/1411be5cc6a464208f41cf94703cde5586b37998

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/e52a677fbced57c550879b7c8d43d81854919c0a

Comment 9

[Alissa（leave from Mozilla）]

Attachment: Vmaster_Verify_screenshort.png

This issue has been verified as pass on latest build of flame master and nexus5 master.
Rate:0/5

Device: Flame master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.193055
Firmware Date          Sun Jul  5 19:31:07 EDT 2015
Bootloader             L1TC000118D0

Device: N5 master[pass]
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150705.193225
Firmware Date          Sun Jul  5 19:32:44 EDT 2015
Bootloader             HHZ12f

Comment 10

[yifan [:yifan][:yliao]]

ni Josh for suggestions on 2.1 & 2.2 approval.

Comment 11

[Josh Cheng [:josh]]

Hi Vance,
Do we still need this for 2.1/2.1S?
Thanks!

Comment 12

[Josh Cheng [:josh]]

Hi Wesley,
Do you need this for feature phone on 2.2r?
Thanks

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

2.2r is a derived branch from 2.2.
We supposedly only add feature phone relevant features and critical bug fixes.
Other than that I think should be the same as 2.2.

Comment 14

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

No, 2.1/2.1s don't need it. However, I think since feature phone still will have wifi signal bar display on the screen, I would recommend to land this one on 2.2R

Thanks