1121413 - [Loop] Incorrect error message shown when trying to join a full room

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[isabelrios]

Attachment: 2015-01-14-08-24-57.png

Flame 2.0 device:
Gecko-5f9dc54
Gaia-31d6c94
Loop master version
User A, B and C logged in mobile loop client 

STR
1. User A creates and shares a room with user B and C
2. User A and B joins the room
3. User C tries to join the room

EXPECTED
An error message is shown: Opps! You can't join because there are already two people in this room.

ACTUAL
The error message is a general one, not the error message defined when joining a full room, Oops! That didn't work as expected. Why don't we give it another try?. Please see screenshot

Comment 1

[Maria Angeles Oteo (:oteo)]

Jose Antonio, as far as I remember you implemented some of these error cases when joining a Room, can you have a look at it when you have time?

Thanks a lot!

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/451

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8548992 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/451

Cristian, would you mind to review this please? Nothing crazy. Thanks!

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8548992 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/451

Your code looks good although I would prefer GET /Rooms/:Token will return the room object instead of returning an error when it is full. Imagine I need to know something related to the room but, as this is full, I cannot know the name, creationTime, etc being the owner... Maybe a field "state" for room objects would make sense for me, of course, this is only my point of view and I could be wrong as usual because I don't know all things related to server and HTTP APIs.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Landed on master at: 

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/9e206bc7e6286d879f751462c08b3a8ebdc57cd5

Comment 6

[isabelrios]

Now the message shown is correct. 
Verified with Fire E 2.0
Loop version:1.1.1/d4d6d37