Closed Bug 1121449 Opened 11 years ago Closed 11 years ago

[Loop] [Telemetry] Renaming rooms

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: opatinobugzilla, Assigned: opatinobugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

proposed patch
61 bytes, text/x-github-pull-request
macajc
: review+
Details | Review
Number of times a room is renamed, and send this information to Telemetry server
Assignee: nobody → opatinobugzilla
Blocks: 1098587
Attached file proposed patch (obsolete) —
Attachment #8548884 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8548884 [details] [review] proposed patch Please write this following the guide lines of the review in bug 1113602
Attachment #8548884 - Flags: review?(carmen.jimenezcabezas) → review-
Depends on: 1113602
Attachment #8548884 - Attachment is obsolete: true
Attached file proposed patch —
Attachment #8551210 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551210 [details] [review] proposed patch I left some comments on git, please take a look and rerequest the review, thanks
Attachment #8551210 - Flags: review?(carmen.jimenezcabezas)
Attachment #8551210 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551210 [details] [review] proposed patch LGTM, I only left a nit in git, thanks!
Attachment #8551210 - Flags: review?(carmen.jimenezcabezas) → review+
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ea5a896f828564f997e652eb1b5910387ade89fc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: