39 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
We have a lot of dependencies in our requirement files, many inherited from Playdoh, that we might not really need anymore. Let's audit what we need and remove what we don't. We also want to make sure all dependencies listed in `prod.txt` are actually needed in production (i.e. when running the app through mod_wsgi). Things related to nose for example could probably be moved to `dev.txt`.
Taking notes: Need to review funfactory.monkeypatches.patch(). Notably accounts may need something, says accounts.tests:AccountsTestCase.test_django_session.csrf. Though the test passes without.
Assignee: nobody → l10n
QA Contact: l10n
Created attachment 8575310 [details] [review] Remove a bunch of stuff we don't need, monkeypatch session_csrf only Peter, I'd like to ask you for review on this one, as the only thing that really needs review here is how I monkeypatch elmo for session_csrf, and how I drop the other monkeys from https://github.com/mozilla/funfactory/blob/d85bcca/funfactory/monkeypatches.py (that's the specific version that elmo uses right now). In order of appearance, the monkeys there seem to be logging (not in elmo) jinja2 (safe_forms, which isn't in nuggets anymore, not in elmo) session_csrf (yes) jinja2, again (not in elmo) Doing a fake PR here, as I want to keep this as a few commits. I might even make an explicit merge commit on this one, too.
Comment on attachment 8575310 [details] [review] Remove a bunch of stuff we don't need, monkeypatch session_csrf only https://github.com/mozilla/elmo/pull/13#issuecomment-78073871
Commits pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/c82d9e9a4144e1323fe763771cddf1b0cb0accc9 bug 1121496, remove Jinja2, jingo dependencies https://github.com/mozilla/elmo/commit/f525687af4a258a2994fc49b929f51e2c1d5b9d6 bug 1121496, remove tower and Babel https://github.com/mozilla/elmo/commit/318531c73b70e424f6858d488ebe4ab7c1a02ab0 bug 1121496, remove cef https://github.com/mozilla/elmo/commit/b4266f17a0561754312d4b544683b95a2551af43 bug 1121496, make dependencies of settings on funfactory explicit https://github.com/mozilla/elmo/commit/56da2d0fdabcc46ea97420064f6f47b6c8ab7ef4 bug 1121496, remove django-multidb-router https://github.com/mozilla/elmo/commit/ed1939128424fde61e73d8a8b7696ae01f11d7bb bug 1121496, remove nuggets https://github.com/mozilla/elmo/commit/a06769d392ba9a0ed90ac3f1447cee3811cb1bd0 bug 1121496, add back the monkeys we need for session_csrf https://github.com/mozilla/elmo/commit/4c0a14ec4e1d89d6dac18f79a47613ba2a1b220e Merge branch 'feature/bug-1121496-dependencies' into develop, r=peterbe. Fixes bug 1121496
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.