1121497 - CoreLocation provider: non responsive until restarted

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[:garvan]

To repro this bug:
Using the CL provider, reload a page with geolocation. You may or may not get a location. In most cases the neither the success or error callback is called.

CLLocationManager starts and stops updating based on startUpdatingLocation and stopUpdatingLocation. By design/docs it will report a location after the first call to start, and is under no obligation to re-report a location until stopped and restarted. It is only guaranteed to report consecutive locations on an actual location change.

Comment 1

[:garvan]

Attachment: CoreLocationLocationProvider.mm: stop listener on Startup

On CoreLocationLocationProvider::Startup(), previously only startUpdatingLocation was called, and consecutive calls to this (as Startup() is called on each page load where HTML 5 geoloc api is called) do nothing. Which would happen on page reloading.

Calling stopUpdatingLocation first will trigger startUpdatingLocation to return a location or failure when it is called.

Comment 2

[:garvan]

Try green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f3f704e0d3

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc42921d3f36

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back out this changes in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e28ef6984108 since one of this changes caused a bustage in  OS X static analysis builds like:

https://treeherder.mozilla.org/logviewer.html#?job_id=5955163&repo=mozilla-inbound

Comment 5

[:garvan]

Bug 1121265 was the problem patch, is fixed.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6bec2021c05

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6bec2021c05