1121509 - Devtools Profiler: FF v35 profiler button should work

Status: RESOLVED WORKSFORME

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[sys.sgx]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150108202552

Steps to reproduce:

On a windows 7 x64, FF v35:

Open the profiler, click the button to start profiling. Wait for 5 sec. Click again the button. The profiler window displays continuously the message "Loading".



Expected results:

The normal profiler should be displayed. Currently, windows users might not be able to to do profiling. Functionality should be restored possibly with an update to make it work as expected.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I tested this in Windows 8.1 with Firefox 35, but it appears to work.

Can you be more specific about your setup?  I assume e10s is not used since it has no option in Release channel.  Do you see this on every page?  Are there any logs in the Browser Console[1] (not the Web Console)?

[1]: https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

Comment 2

[sys.sgx]

The setup is very simple. I just tested in order to profile this page on bugzilla, and it seems to not function at all now. Note that this happens while in private mode window, haven't yet tested on the normal mode.

So, with clean browser console, I open up the devtools in the current page and click the "profile" button. Seems to not be working, and then I click again the "profile" button to stop the profiling. That moment, here's what's displayed on the browser console:


error occurred while processing 'getProfile: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProfiler.getProfileData]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/profiler.js :: ProfilerActor.prototype.onGetProfile :: line 116"  data: no]
Stack: ProfilerActor.prototype.onGetProfile@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/profiler.js:116:18
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1407:14
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:10
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:13
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:13
Line: 116, column: 0 main.js:1279

onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'getProfile: [Exception... \"Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProfiler.getProfileData]\"  nsresult: \"0x80004005 (NS_ERROR_FAILURE)\"  location: \"JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/profiler.js :: ProfilerActor.prototype.onGetProfile :: line 116\"  data: no]\nStack: ProfilerActor.prototype.onGetProfile@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/profiler.js:116:18\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1407:14\nLocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:10\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:13\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:13\nLine: 116, column: 0"}
Stack: DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:873:1
resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
then@resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:869:1
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
Line: 873, column: 0 DevToolsUtils.js:59

A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Wed Jan 14 2015 19:50:20 GMT+0200
Full Message: TypeError: "to" is read-only shared.js:171

See the attached file.

Comment 3

[sys.sgx]

Attachment: console.gif

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to sys.sgx from comment #2)
> The setup is very simple. I just tested in order to profile this page on
> bugzilla, and it seems to not function at all now. Note that this happens
> while in private mode window, haven't yet tested on the normal mode.

Ah, that's an important difference.  This sounds like a duplicate of bug 896222, so it's a known issue that it does not work in private mode.

Can you confirm that it does work correctly in normal mode?

Comment 5

[sys.sgx]

So, well, there are multiple bugs I think. Here's the case:

1. If you are on a normal window, with clear browser cache, and you have not previously opened the devtools in a private mode window, the profiler button works when you first click it (it starts "profiling"), but then when you click it again to stop profiling, the right area simply displays "Loading".

2. If you are on a private mode window, it does not work at all.

3. If you are on a normal mode window, but you have previously opened the profiler in private mode, it doesn't work at all.

I wonder what has changed between versions, it used to work fine. I suppose there has been a major overhaul to its functionality.

Comment 6

[Victor Porof [:vporof][:vp]]

This should work properly now in the new perf tool (Firefox Nightly). Please reopen if it's still an issue. Thanks!