1121610 - Sync on Android: 'WiFi' should be 'Wi-Fi'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

See bug 1098667 comment 11:

sync_strings.dtd
<!ENTITY fxaccount_finish_migrating_description 'Upgrading can transfer a lot of data. It\&apos;s best to be on a WiFi network.'>

"Wi-Fi" is the term used in Firefox for Android.

Comment 1

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8549068 [details] [diff] [review]
patch, v1

Review of attachment 8549068 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 2

[Richard Newman [:rnewman]]

This needs to land on GitHub: 

https://github.com/mozilla-services/android-sync/blob/develop/strings/sync_strings.dtd

You can send a pull request straight from the website.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

That string (fxaccount_finish_migrating_description) can be found in the file you linked ( https://github.com/mozilla-services/android-sync/blob/develop/strings/sync_strings.dtd )

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v1

Nevermind, GH ate my keyboard shortcuts.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/521

ni to me to land.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/a57f75ad12f1

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a57f75ad12f1

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8549215 [details] [review]
pull request, v1

I've landed this.