Closed Bug 1121683 Opened 5 years ago Closed 5 years ago
Implement a location widget
Implement a location widget that shows the https status, location and reader mode button.
I have a branch ready that I will submit a PR for when the first iteration of the Reader Mode has been merged.
This is an implementation for a new BrowserLocationView that displays and manages the following items: * A padlock icon which is set when the requested URL is https * The URL location * he Reader Mode button
Comment on attachment 8550013 [details] [review] Pull Request LGTM
Attachment #8550013 - Flags: review+ → review?(bnicholson)
Ignore last comment. I typed in the wrong bug window again. Was for 1121228 instead.
Comment on attachment 8550013 [details] [review] Pull Request Heh, I saw this got merged early again. Not worth reverting again, but please at least comment on or file follow-ups for my last couple comments in the PR.
Updated PR here: https://github.com/mozilla/firefox-ios/pull/93
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.