Implement a location widget

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Implement a location widget that shows the https status, location and reader mode button.
(Assignee)

Comment 1

4 years ago
I have a branch ready that I will submit a PR for when the first iteration of the Reader Mode has been merged.
(Assignee)

Comment 2

4 years ago
Created attachment 8550013 [details] [review]
Pull Request
Attachment #8550013 - Flags: review?(bnicholson)
(Assignee)

Comment 3

4 years ago
This is an implementation for a new BrowserLocationView that displays and manages the following items:

* A padlock icon which is set when the requested URL is https
* The URL location
* he Reader Mode button
(Assignee)

Comment 4

4 years ago
Comment on attachment 8550013 [details] [review]
Pull Request

LGTM
Attachment #8550013 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

4 years ago
Attachment #8550013 - Flags: review+ → review?(bnicholson)
(Assignee)

Comment 5

4 years ago
Ignore last comment. I typed in the wrong bug window again. Was for 1121228 instead.
Comment on attachment 8550013 [details] [review]
Pull Request

Heh, I saw this got merged early again. Not worth reverting again, but please at least comment on or file follow-ups for my last couple comments in the PR.
Attachment #8550013 - Flags: review?(bnicholson) → review+
Updated PR here: https://github.com/mozilla/firefox-ios/pull/93
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.