1121683 - Implement a location widget

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Implement a location widget that shows the https status, location and reader mode button.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have a branch ready that I will submit a PR for when the first iteration of the Reader Mode has been merged.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Pull Request

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is an implementation for a new BrowserLocationView that displays and manages the following items:

* A padlock icon which is set when the requested URL is https
* The URL location
* he Reader Mode button

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8550013 [details] [review]
Pull Request

LGTM

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Ignore last comment. I typed in the wrong bug window again. Was for 1121228 instead.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8550013 [details] [review]
Pull Request

Heh, I saw this got merged early again. Not worth reverting again, but please at least comment on or file follow-ups for my last couple comments in the PR.

Comment 7

[Brian Nicholson (:bnicholson)]

Updated PR here: https://github.com/mozilla/firefox-ios/pull/93