Closed
Bug 1121731
Opened 9 years ago
Closed 9 years ago
Port places library from mozmill-tests repository
Categories
(Testing :: Firefox UI Tests, defect, P2)
Testing
Firefox UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [lib])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1121725 +++ To be able to create the first tabbed browsing tests with Marionette, we need the tabs module being ported from JS to Python. It can be found here: http://hg.mozilla.org/qa/mozmill-tests/file/default/lib/places.js Some necessary features need support for observer notifications. So its blocked on bug 1121691.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
WIP for the places library. It misses tests which I'm going to write now. If you have the time to glance over it would be great. Keep in mind that we still have limitations and cannot convert wait_for_visited() yet due to missing observer handling.
Attachment #8559861 -
Flags: feedback?(cmanchester)
Comment 2•9 years ago
|
||
Comment on attachment 8559861 [details] [review] github_pull_request.txt Looking good so far. I left some comments in github.
Attachment #8559861 -
Flags: feedback?(cmanchester) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8559861 [details] [review] github_pull_request.txt The PR has been updated and should be complete now. Travis is currently running and should complete without failures.
Attachment #8559861 -
Flags: review?(cmanchester)
Comment 4•9 years ago
|
||
Comment on attachment 8559861 [details] [review] github_pull_request.txt Just a few things in github. I'd like to see it again.
Attachment #8559861 -
Flags: review?(cmanchester)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8559861 [details] [review] github_pull_request.txt Review comments have been addressed, and changes are uploaded.
Attachment #8559861 -
Flags: review?(cmanchester)
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
Version: Version 2 → unspecified
Comment 6•9 years ago
|
||
Comment on attachment 8559861 [details] [review] github_pull_request.txt A few nits in github, but we're good to go here. Thanks.
Attachment #8559861 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 7•9 years ago
|
||
All nits have been addressed, and the PR has been merged as https://github.com/mozilla/firefox-ui-tests/commit/8c2dad20dc465795025565393cb364f9eaa3bca8 We are now unblocked for locationbar tests!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Assignee | ||
Updated•9 years ago
|
Priority: P1 → P2
Updated•8 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•