1121731 - Port places library from mozmill-tests repository

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

+++ This bug was initially created as a clone of Bug #1121725 +++

To be able to create the first tabbed browsing tests with Marionette, we need the tabs module being ported from JS to Python. It can be found here:

http://hg.mozilla.org/qa/mozmill-tests/file/default/lib/places.js

Some necessary features need support for observer notifications. So its blocked on bug 1121691.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

WIP for the places library. It misses tests which I'm going to write now. If you have the time to glance over it would be great. Keep in mind that we still have limitations and cannot convert wait_for_visited() yet due to missing observer handling.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8559861 [details] [review]
github_pull_request.txt

Looking good so far. I left some comments in github.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8559861 [details] [review]
github_pull_request.txt

The PR has been updated and should be complete now. Travis is currently running and should complete without failures.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8559861 [details] [review]
github_pull_request.txt

Just a few things in github. I'd like to see it again.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8559861 [details] [review]
github_pull_request.txt

Review comments have been addressed, and changes are uploaded.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8559861 [details] [review]
github_pull_request.txt

A few nits in github, but we're good to go here. Thanks.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All nits have been addressed, and the PR has been merged as https://github.com/mozilla/firefox-ui-tests/commit/8c2dad20dc465795025565393cb364f9eaa3bca8

We are now unblocked for locationbar tests!