Closed Bug 1121767 Opened 9 years ago Closed 8 years ago
Stopwatch: key "FX _PAGE _LOAD _MS" was already initialized
I see this error in the browser console when logging into the Yammer using Okta SSO, but only when e10s is enabled: https://www.yammer.com/mozilla.com TelemetryStopwatch: key "FX_PAGE_LOAD_MS" was already initialized
This is not an e10s bug, I see it in single-process desktop Developer Edition 41: "TelemetryStopwatch: key "FX_PAGE_LOAD_MS" was already initialized" Nick: I think you're seeing a different error. This isn't a bug in TelemetryStopwatch, it's a bug in the code that uses it. TelemetryStopwatch just calls Cu.reportError when it notices it's being used incorrectly. Tim: How can TelemetryStopwatch.start("FX_PAGE_LOAD_MS", ...) get called twice before TelemetryStopwatch.finish("FX_PAGE_LOAD_MS", ..) ever gets called? Two tabs being loaded simultaneously?
Loading https://www.yammer.com/mozilla.com in a tab I indeed see: start, start, stop, stop If I assume that the first "stop" belongs to the first "start" then that would also mess with the measurements if we'd always cancel() before start(). And those are supposed to be top-level loads, hm.
Yeah a more unique key passed to TelemetryStopwatch would help
Note that the key is not compared for deep equality. It's only checked as a reference to the same object. Maybe changing the key from aBrowser to aRequest would work, if the aRequest received on finish is the same obj as the one received on start (I imagine it is)
WFM in Nightly 47.
You need to log in before you can comment on or make changes to this bug.