Closed Bug 1121806 Opened 5 years ago Closed 5 years ago

show_bug does not display in IE9

Categories

(Bugzilla :: Creating/Changing Bugs, defect, major)

4.5.6
All
Windows 7
defect
Not set
major

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: altlist, Assigned: altlist)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch v1Splinter Review
show_bug.cgi does not display in IE9.  In particular, it fails when attempting to call this line, because commentTagging hash is not defined

bug/edit.html.tmpl:YAHOO.bugzilla.commentTagging.init()

Problem is that IE9 silently drops the bug.js code due to dangling commas.  The attached patch fixes the issue.
Attachment #8549334 - Attachment is patch: true
Attachment #8549334 - Attachment mime type: text/x-patch → text/plain
This is probably a blocker for 5.0.
FYI, I ran jshint on js/*.  While there were various warnings, such as missing semi-colons, the only IE related errors were the dangling commas in js/bug.js
WFM using IE11 on Windows 7.
Assignee: create-and-change → altlist
Flags: blocking5.0+
Attachment #8549334 - Flags: review?(dylan)
Status: NEW → ASSIGNED
Depends on: 489028
Keywords: regression
Target Milestone: --- → Bugzilla 5.0
Comment on attachment 8549334 [details] [diff] [review]
v1

Review of attachment 8549334 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

the previous content is a syntax error in emacs (js2-mode). Yeesh.
Attachment #8549334 - Flags: review?(dylan) → review+
Flags: approval?
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   8820144..367d9c2  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   e3e7b71..272b0b6  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.