1121814 - [Stingray][smart-system] use latest NotificationHelper to show notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

1) https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/app-deck/js/context_menu.js#L77-L84

This is fortunately not true.

1) bluetooth seems to be using old NotificationHelper. It should be synced with the one from shared, which returns a Promise and support L10n API properly.

2) tv_apps/smart-system/js/captive_portal.js, tv_apps/smart-system/js/screenshot.js and tv_apps/smart-system/js/devtools/logshake.js should use the new NotificationHelper instead of raw W3C Notification.

3) Same for tv_apps/smart-system/js/external_storage_monitor.js

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

You should just switch to https://github.com/mozilla-b2g/gaia/blob/master/shared/js/notification_helper.js

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

I had created a WIP 11 days ago:
https://github.com/huchengtw-moz/gaia/commit/3792f421a87e3a87b1dfd6f93d296756ee87696a

Because I got the high priority works recently, I cannot work on it. If someone want to take it, please steal the bug. I will be back once those works done.

Comment 3

[Rohan Rawat]

Attachment: Gaia PR

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Rohan

Thanks for giving the patch. I reassign this bug to you. And I will review the patch in this week.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8557449 [details] [review]
Gaia PR

Looks good to me. Thank you. I will land the code for you.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/4a99698691bd09670e81b675cada794815eb8bd0
gaia try is all green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b9430f804317

Comment 7

[Rohan Rawat]

I was wondering if this also fixed bug 967925 ?

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Well, this is a good question. If you apply the patch to "phone's" system app who is at /apps/system/, it is true that you also fixed bug 967925.

But smart system is for smart screen. So, please find the bug similar to this one and fix it.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Here is the information about smart screen:
https://wiki.mozilla.org/FirefoxOS/Stingray/SmartScreen/