Closed Bug 1121814 Opened 8 years ago Closed 8 years ago
[Stingray][smart-system] use latest Notification
Helper to show notification
1) https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/app-deck/js/context_menu.js#L77-L84 This is fortunately not true. 1) bluetooth seems to be using old NotificationHelper. It should be synced with the one from shared, which returns a Promise and support L10n API properly. 2) tv_apps/smart-system/js/captive_portal.js, tv_apps/smart-system/js/screenshot.js and tv_apps/smart-system/js/devtools/logshake.js should use the new NotificationHelper instead of raw W3C Notification. 3) Same for tv_apps/smart-system/js/external_storage_monitor.js
You should just switch to https://github.com/mozilla-b2g/gaia/blob/master/shared/js/notification_helper.js
I had created a WIP 11 days ago: https://github.com/huchengtw-moz/gaia/commit/3792f421a87e3a87b1dfd6f93d296756ee87696a Because I got the high priority works recently, I cannot work on it. If someone want to take it, please steal the bug. I will be back once those works done.
Attachment #8557449 - Flags: review?(timdream) → review?(im)
Rohan Thanks for giving the patch. I reassign this bug to you. And I will review the patch in this week.
Assignee: im → rohan1395
Comment on attachment 8557449 [details] [review] Gaia PR Looks good to me. Thank you. I will land the code for you.
Attachment #8557449 - Flags: review?(im) → review+
merged to master: https://github.com/mozilla-b2g/gaia/commit/4a99698691bd09670e81b675cada794815eb8bd0 gaia try is all green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b9430f804317
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
I was wondering if this also fixed bug 967925 ?
Well, this is a good question. If you apply the patch to "phone's" system app who is at /apps/system/, it is true that you also fixed bug 967925. But smart system is for smart screen. So, please find the bug similar to this one and fix it.
Here is the information about smart screen: https://wiki.mozilla.org/FirefoxOS/Stingray/SmartScreen/
You need to log in before you can comment on or make changes to this bug.