1121823 - There should be an option to disable the lockscreen search shortcut.

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Antoine]

Currently there's no way to disable the swipe-up search shortcut on the lockscreen, which also automatically enables the Camera shortcut.

Comment 1

[Aaron Train [:aaronmt]]

Which version of Android are you using? I'm on Android 5.0.1 and on my lock-screen I just have access to the dialler and camera.

Comment 2

[Antoine]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Which version of Android are you using? I'm on Android 5.0.1 and on my
> lock-screen I just have access to the dialler and camera.

4.4.4, pretty much stock (phone is Moto G).

I normally don't have anything on the lock screen besides the clock and the slide-unlock widget.
After updating to FF35 I now have the slide-up search shortcut and the camera icon on the right.

If I uninstall Firefox, the shortcuts go away.

Comment 3

[Aaron Train [:aaronmt]]

Thanks. I agree we shouldn't be interfering with system operations opening the camera.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I can't reproduce this on my 4.3 and 4.4 devices. I can get the swipe-up gesture to display the list of Search Activities (Firefox and Google). Tapping one of them opens the search app. The camera app does not open.

If I could reproduce the Camera issue, we'd try to fix it. We have no way to "turn off" the swipe gesture. It's hard coded in the application manifest and Android seems to be responsible for activating it in your lockscreen. Maybe Motorola is not shipping the Google search app, so it doesn't show up for you?

Comment 5

[Antoine]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Maybe Motorola is not shipping the Google search app
I disabled it manually.
Chrome for Android doesn't trigger those lockscreen shortcuts. I only have FF's activity in there.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I notice some references to KEYGUARD in the Search code. Should this be removed?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/SearchWidget.java#108

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Note that the code in comment 6 is not in the Search activity, but is in the Homescreen widget. It should have no affect on the Search activity. Just double checking.

Comment 8

[Wesley Johnston (:wesj)]

(In reply to Mark Finkle (:mfinkle) from comment #7)
> Note that the code in comment 6 is not in the Search activity, but is in the
> Homescreen widget. It should have no affect on the Search activity. Just
> double checking.

Yeah. That code should run if we're on a lockscreen, since we had a slightly different layout there. If it was running, we'd see it. But its vestigial at this point. I'll file a good-first-bug to remove it.