PluginTypes.h missing in xulrunner -36-sdk in folder/include/mozilla/plugins/

RESOLVED FIXED in Firefox 39

Status

()

defect
--
major
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: xuchmao, Assigned: ted)

Tracking

unspecified
mozilla39
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: xulrunner-36-sdk file missing)

Attachments

(1 attachment, 1 obsolete attachment)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

When I use the xulrunner-36.0b1.en-US.win32.sdk to compile my extension of firefox support. The compiler report an error as Cannot open include file: 'mozilla/plugins/PluginTypes.h': No such file or directory



Actual results:

In the xulrunner-36-sdk, file nsPluginHost.h has included a file PluginTypes.h just like #include "mozilla/plugins/PluginTypes.h".
But file do not exsist in folder /include/mozilla/plugins/.


Expected results:

PluginTypes.h should be in /include/mozilla/plugins/ in xulrunner-36-sdk
Severity: normal → major
Summary: File PluginTypes.h in xulrunner -36-sdk under folder/include/mozilla/plugins/ → PluginTypes.h missing in xulrunner -36-sdk in folder/include/mozilla/plugins/
Group: core-security
Component: Untriaged → Documentation
Product: Firefox → Add-on SDK
Version: 36 Branch → unspecified
Whiteboard: SDK file missing
Whiteboard: SDK file missing → xulrunner-36-sdk file missing
How and/or what did you build?

PluginTypes.h is generated by the build system from an ipdl file, from the looks of it:

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/moz.build#113

So it sounds like for some reason your build didn't do that.
Component: Documentation → Build Config
Flags: needinfo?(xuchmao)
Product: Add-on SDK → Core
Georg, would you know more about how this is meant to work for the SDK?
Flags: needinfo?(gfritzsche)
This is an IPDL-generated file. The SDK doesn't currently include these files, they have to be generated again during a build.

Extensions shouldn't be including nsPluginHost.h anyway; that's an internal header.
Flags: needinfo?(gfritzsche)
The xulrunner-36.0b1.en-US.win32.sdk I used is downloaded from ftp://ftp.mozilla.org/pub/mozilla.org/xulrunner/releases/36.0b1/sdk/. 

(In reply to :Gijs Kruitbosch from comment #1)
> How and/or what did you build?
> 
> PluginTypes.h is generated by the build system from an ipdl file, from the
> looks of it:
> 
> http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/moz.build#113
> 
> So it sounds like for some reason your build didn't do that.
Flags: needinfo?(xuchmao)
In my extension I have included a file 'nsPluginInstanceOwner.h', and nsPluginInstanceOwner.h has inlcude nsPluginHost.h.

Do PluginTypes.h will be inlcuded in next sdk release ?

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> This is an IPDL-generated file. The SDK doesn't currently include these
> files, they have to be generated again during a build.
> 
> Extensions shouldn't be including nsPluginHost.h anyway; that's an internal
> header.
I have build the sdk using the source code downloaed from ftp://ftp.mozilla.org/pub/mozilla.org/xulrunner/releases/36.0b1/source/
PluginTypes.h also do not exsist in /include/mozilla/plugins/.

What should I do if want this file exports to /include/mozilla/plugins 

(In reply to :Gijs Kruitbosch from comment #1)
> How and/or what did you build?
> 
> PluginTypes.h is generated by the build system from an ipdl file, from the
> looks of it:
> 
> http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/moz.build#113
> 
> So it sounds like for some reason your build didn't do that.
This file is not part of the SDK. It is an IPDL-generated file that you would need to generate yourself. However, you shouldn't need to be including any of the plugin implementation files including nsPluginInstanceOwner or nsPluginHost.
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Per comment 5, he's including nsPluginHost.h, which includes PluginTypes.h:
https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginHost.h#31

If we're including nsPluginHost.h in the SDK then we should fix it to not include that generated header.
Status: RESOLVED → REOPENED
Component: Build Config → Plug-ins
Ever confirmed: true
Resolution: WONTFIX → ---
Posted file MozReview Request: bz://1121845/ted (obsolete) —
/r/3395 - bug 1121845 - Don't include generated IPDL header from nsPluginHost.h

Pull down this commit:

hg pull review -r 22cd1e9c5c0968fe40903f27efc4328f9db992a4
Attachment #8559764 - Flags: review?(benjamin)
Comment on attachment 8559764 [details]
MozReview Request: bz://1121845/ted

/r/3395 - bug 1121845 - Don't include generated IPDL header from nsPluginHost.h

Pull down this commit:

hg pull review -r 22cd1e9c5c0968fe40903f27efc4328f9db992a4
Assignee: nobody → ted
Comment on attachment 8559764 [details]
MozReview Request: bz://1121845/ted

https://reviewboard.mozilla.org/r/3393/#review2847

Ship It!
Attachment #8559764 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/3c4488d4d607
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8559764 - Attachment is obsolete: true
Attachment #8619134 - Flags: review+
You need to log in before you can comment on or make changes to this bug.