Introducing the undo action in the toast in SMS app

RESOLVED WONTFIX

Status

Firefox OS
Gaia::SMS
RESOLVED WONTFIX
3 years ago
8 months ago

People

(Reporter: rishav_, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
This is follow up bug 1037650.
Here we will introduce the undo action for delete and read/unread functionality.
(Reporter)

Updated

3 years ago
Depends on: 1037650
(Reporter)

Updated

3 years ago
Blocks: 1088502
(Reporter)

Updated

3 years ago
Assignee: nobody → rishav006
(Reporter)

Updated

3 years ago
Mentor: felash@gmail.com

Comment 1

3 years ago
Created attachment 8588341 [details] [review]
[gaia] kumarrishav:Bug-1121863 > mozilla-b2g:master
(Reporter)

Comment 2

2 years ago
[New feature]
Postponed till V2.5 release.
(Reporter)

Updated

2 years ago
Assignee: rishav006 → nobody
(Reporter)

Comment 3

2 years ago
Hi Bryant,
I would like to know your views on it. When we can/should have it for release. How good this feature is. etc.

As lot's of UI/UX involved in this. 
Also, Bug 1037650

Thanks
Flags: needinfo?(bmao)
Hi Kumar,

I think it's okay to use undo toast for the mark as Read/Unread action, since it's not a big deal if user accidentally trigger the action.  

But I have little concern to use it on the delete action, and I'll say it depends on what we want to delete. If we just want to delete a dialogue bubble in the conversation, the undo toast will be fine. 

However, If we want to delete the entire conversation, that's a different story. It would be a important decision which confirmation box might be better for user to ponder a little and consider what will happen when they delete it (Showing "all files and history will be removed"), and if they miss the timing to tap "undo", they will lose the conversation forever.

What do you think?
Flags: needinfo?(bmao)
(Reporter)

Comment 5

2 years ago
umm, I think you are right. 
IMO, importance of delete option should be same in conversation and inbox, and it's up to 'user' to take decision which is important. So, i would suggest to add undo without removing the confirmation dialog.

Confirmation dialog is indeed a good obstacle that warn user before taking delete action.
So, i think, let it be like this and add undo feature (for both, i.e read/unread as well as delete for conversation and inbox) on this. 
Then after this, let's see feedback/response from user, if they feel dialog is not important anymore over undo, then we will decide accordingly in future.

What you say?
I guess that one way to test the feature although it's bit redundant. Another way is to remove the confirmation dialog entirely and see what happen, but i think it would be too risky as user might lose their precious data.
(Reporter)

Comment 7

2 years ago
Yeah, it's bit redundant but i guess,it won't give a feel of redundancy to user as the undo toast will appear at the bottom and it won't be a obstacle in user's activity. 

ni? julienw for his view.

Hey julienw,
Have a look on comment 4, 5, 6 and tell your opinions.

Thanks
Flags: needinfo?(felash)
(Reporter)

Comment 8

2 years ago
Hey Bryant,
How about having undo toast as in message setting, where user can decide whether they want to enable or disable it. By default it will be enabled.

Thanks
Flags: needinfo?(bmao)
I think that what Bryant says in comment 4 makes sense.
Flags: needinfo?(felash)
(Reporter)

Comment 10

2 years ago
Hi Bryant,
Okay fine :) Julienw also agree with you.

It will be nice if i can have new UI/UX for this bug.

Thanks
(In reply to kumar rishav (:rishav_) from comment #8)
> Hey Bryant,
> How about having undo toast as in message setting, where user can decide
> whether they want to enable or disable it. By default it will be enabled.
> 
> Thanks

I guess we could give user an option for that, although they usually stick with default. And if they disable, we need to think what the feedback will be when they do the actions. Would it be a dialogue? a toast without undo? or simply show nothing? (Which i don't suggested)

My feeling is we can put this in later discussion, right now we can focus more on how user value the "undo" action, and what their behavior/attitude around the action.
Flags: needinfo?(bmao)
(In reply to kumar rishav (:rishav_) from comment #10)
> Hi Bryant,
> Okay fine :) Julienw also agree with you.
> 
> It will be nice if i can have new UI/UX for this bug.
> 
> Thanks

you mean the spec?
(Reporter)

Comment 13

2 years ago
Yeah, Old spec is not good enough now i guess, as now UI/UX got change, like when to confirm box, when not etc.
(Reporter)

Updated

2 years ago
Flags: needinfo?(bmao)
Created attachment 8692361 [details]
SMS_undo_toast_spec.pdf

Hi Kumar,

Here are the spec for undo toast in SMS, please take a look :)
Flags: needinfo?(bmao)
(Reporter)

Comment 15

2 years ago
Hi Bryant,
Thanks a lot :) it looks great. I was wondering if we can get better strings?

Hi julien,
Can we have better string or it's fine?

Thanks
Flags: needinfo?(felash)
(Reporter)

Comment 16

2 years ago
Hi Fang,
Can we have VD spec for the toast given in Bryant's UX Spec?
Btw currently we have two types of toast in Firefox OS (IIRC), one we have in SMS (while saving msg as draft) and other when installing any app or add-on.
Thanks
Flags: needinfo?(fshih)
I think we need better strings, I see there are mistakes in these.

Hey Matej, do you have the time to take a look at the strings in the spec in attachment 8692361 [details] ?


(In reply to kumar rishav (:rishav_) from comment #16)
> Hi Fang,
> Can we have VD spec for the toast given in Bryant's UX Spec?
> Btw currently we have two types of toast in Firefox OS (IIRC), one we have
> in SMS (while saving msg as draft) and other when installing any app or
> add-on.


I think we'll just reuse the same style as the ones we have for drafts. What do you think Fang ?
As for the "undo" icon, I see we have 2 undo icons in the font: undo-circular [1] and undo [2]. Bryant's spec shows the circular one, but maybe you think otherwise :)

[1] https://github.com/gaia-components/gaia-icons/blob/master/images/undo-circular.svg
[2] https://github.com/gaia-components/gaia-icons/blob/master/images/undo.svg
Flags: needinfo?(felash) → needinfo?(matej)
(In reply to Julien Wajsberg [:julienw] from comment #17)
> I think we need better strings, I see there are mistakes in these.
> 
> Hey Matej, do you have the time to take a look at the strings in the spec in
> attachment 8692361 [details] ?

Sure thing. Is it just the copy on page 5, or on pages 3 and 4 as well?
Page 3 and 4 as well, if you can.

Thanks a lot !
Sure thing. Here's the updated copy:

[PAGE 3]

Selected thread has been marked as unread

3 selected threads have been marked as unread

Selected thread has been marked as read

3 selected threads have been marked as read

[PAGE 4]

Selected message has been deleted

3 selected messages have been deleted

[PAGE 5]

Delete selected thread? All history in the thread will be removed as well.

Delete 3 selected threads? All history in the threads will be removed as well.
Flags: needinfo?(matej)

Comment 21

2 years ago
(In reply to Julien Wajsberg [:julienw] from comment #17)
> I think we need better strings, I see there are mistakes in these.
> 
> Hey Matej, do you have the time to take a look at the strings in the spec in
> attachment 8692361 [details] ?
> 
> 
> (In reply to kumar rishav (:rishav_) from comment #16)
> > Hi Fang,
> > Can we have VD spec for the toast given in Bryant's UX Spec?
> > Btw currently we have two types of toast in Firefox OS (IIRC), one we have
> > in SMS (while saving msg as draft) and other when installing any app or
> > add-on.
> 
> 
> I think we'll just reuse the same style as the ones we have for drafts. What
> do you think Fang ?
> As for the "undo" icon, I see we have 2 undo icons in the font:
> undo-circular [1] and undo [2]. Bryant's spec shows the circular one, but
> maybe you think otherwise :)
> 
> [1]
> https://github.com/gaia-components/gaia-icons/blob/master/images/undo-
> circular.svg
> [2] https://github.com/gaia-components/gaia-icons/blob/master/images/undo.svg

Hi Julien,

Sorry for the late reply. I agree with you, it's better we use the same undo toast as our other apps ( Email) . And the circle one is the newest undo icon we have. Thanks!
Flags: needinfo?(fshih)

Comment 22

2 years ago
Sorry, I was mean to say the circle one is old one. Can we use  https://github.com/fxos-components/fxos-icons/blob/master/images/undo.svg   for undo. Thank you!!
(Reporter)

Comment 23

2 years ago
Hi Julienw,
In page 5, Does this string give clear info. I mean, a bit odd for user i guess. (like history in thread...) 
"Delete selected thread? All history in the thread will be removed as well"

I think "Delete selected thread should be enough as we already have confirm box like what we have currently."

Thansks
Flags: needinfo?(felash)
(In reply to Matej Novak [:matej] from comment #20)
> Sure thing. Here's the updated copy:
> 
> [PAGE 3]
> 
> Selected thread has been marked as unread
> 
> 3 selected threads have been marked as unread
> 
> Selected thread has been marked as read
> 
> 3 selected threads have been marked as read
> 
> [PAGE 4]
> 
> Selected message has been deleted
> 
> 3 selected messages have been deleted
> 
> [PAGE 5]
> 
> Delete selected thread? All history in the thread will be removed as well.
> 
> Delete 3 selected threads? All history in the threads will be removed as
> well.

Hey Matej, what do you think about using the word "conversation" instead of "thread" ? We try to move out of the "thread" terminology. Not sure what you think ?



(In reply to kumar rishav (:rishav_) from comment #23)
> Hi Julienw,
> In page 5, Does this string give clear info. I mean, a bit odd for user i
> guess. (like history in thread...) 
> "Delete selected thread? All history in the thread will be removed as well"
> 
> I think "Delete selected thread should be enough as we already have confirm
> box like what we have currently."
> 
> Thansks

Not sure what you mean Kumar; can you explain better what you don't like in the proposed string ?
Flags: needinfo?(felash) → needinfo?(matej)
(In reply to Julien Wajsberg [:julienw] from comment #24)
> (In reply to Matej Novak [:matej] from comment #20)
> 
> Hey Matej, what do you think about using the word "conversation" instead of
> "thread" ? We try to move out of the "thread" terminology. Not sure what you
> think ?

I think that's a good idea. And looking at it again, I would add "the" in front of it as well to make it a little friendlier. Here's everything again with the updates:


[PAGE 3]

The selected conversation has been marked as unread

3 selected conversations have been marked as unread

The selected conversation has been marked as read

3 selected conversations have been marked as read

[PAGE 4]

The selected message has been deleted

3 selected messages have been deleted

[PAGE 5]

Delete the selected conversation? All history in the conversation will be removed as well.

Delete 3 selected conversations? All history in the conversations will be removed as well.
Flags: needinfo?(matej)
Looks perfect to me, thanks  !
(Reporter)

Comment 27

2 years ago
(In reply to Julien Wajsberg [:julienw] (PTO -> 2016) from comment #24)
> 
> Not sure what you mean Kumar; can you explain better what you don't like in
> the proposed string ?

I meant,
"Delete the selected conversation? All history in the conversation will be removed as well"

What does "All history in the conversation" signify? I mean, term "history" feels not so general when we talk about SMS or messages. Isn't  "All conversations will be removed as well" or "All previous conversations will be removed as well" enough? 

Though present string proposed by Matej looks good to me.

Thanks
(Reporter)

Updated

2 years ago
Duplicate of this bug: 1037650
The word "history" feels good to me in this case :) The word has several meanings, you can look at [1] to understand better.
In this case it's "A record of previous user events", like a "browser history".

[1] https://en.wiktionary.org/wiki/history
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.