1121865 - Tapping blank space should not exit Homescreen edit mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

*Description:
Spec defines: "To exit edit mode the user can tap done or tap the home button", but currently I can exit edit mode by tapping blank space at an expanded group.

*2.2 UX Spec page 15:
https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2709316676/24961186345/1

*Env:
Build ID               20150114002502
Gaia Revision          7c5b27cad370db377b18a742d3f3fdb0070e899f
Gaia Date              2015-01-12 17:32:38
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150114.040029
Firmware Date          Wed Jan 14 04:00:40 EST 2015
Bootloader             L1TC000118D0

Comment 1

[Chris Lord [:cwiiis]]

Not an app-grouping bug, but a pre-existing homescreen behaviour that we now want changed.

Comment 2

[Gregor Wagner [:gwagner]]

Not holding the release for it.

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Don't dismiss edit mode when tapping a blank space

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8552458 [details] [review]
Don't dismiss edit mode when tapping a blank space

lgtm.

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/f0a247f015227a18050e03e75a7dd8c877fb1ca8

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8552458 [details] [review]
Don't dismiss edit mode when tapping a blank space

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Tapping a blank area in edit mode dismisses the edit screen, which is incongruous with other behaviour and unexpected.
[Testing completed]: On master for a couple of days
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/bc50a71f13ccc5dfed7cfece54ebf73512e86f75

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

verify v2.2

--env info--
Build ID               20150125002503
Gaia Revision          0518f4581a0925c0b703d730ef289ab15cbd1216
Gaia Date              2015-01-24 20:56:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150125.035924
Firmware Date          Sun Jan 25 03:59:36 EST 2015
Bootloader             L1TC000118D0

Comment 10

[SandKing]

Attachment: Verify video: verified_Flame_master.3GP

This bug has been verified as pass on latest Nightly build of Flame master and Nexus5 master.

STR:
1. Long press a blank place on Homescreen.
2. After the homescreen edit mode is opened, then tap other blank place

Actual results: Device does not exit the Homescreen edit mode.
See attachment: verified_Flame_master.3GP
Reproduce rate: 0/8

Device: Flame master build(Pass)
Build ID               20150721160205
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150721.194129
Firmware Date          Tue Jul 21 19:41:42 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 master(pass):
Build ID               20150721160205
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150721.211608
Firmware Date          Tue Jul 21 21:16:23 EDT 2015
Bootloader             HHZ12f