Closed Bug 1121878 Opened 5 years ago Closed 5 years ago

Fix some missing map between WM_APPCOMMAND and KeyboardEvent.key

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- unaffected
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

In Bug 865561, I mapped a lot of commands of WM_APPCOMMAND to KeyboardEvent.key. However, I missed to map some commands.
Attached patch PatchSplinter Review
Current mapping is here:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.key#Key_values_of_WM_APPCOMMAND_message_on_Windows

D3E doesn't define some key names for APPCOMMAND_BASS_BOOST, APPCOMMAND_CORRECTION_LIST, APPCOMMAND_DICTATE_OR_COMMAND_CONTROL_TOGGLE, APPCOMMAND_MIC_ON_OFF_TOGGLE, APPCOMMAND_MICROPHONE_VOLUME_DOWN, APPCOMMAND_MICROPHONE_VOLUME_MUTE, APPCOMMAND_MICROPHONE_VOLUME_UP, APPCOMMAND_TREBLE_DOWN and APPCOMMAND_TREBLE_UP.

So, APPCOMMAND_COPY, APPCOMMAND_CUT, APPCOMMAND_MEDIA_CHANNEL_DOWN, APPCOMMAND_MEDIA_CHANNEL_UP and APPCOMMAND_MEDIA_FAST_FORWARD should be mapped.
Attachment #8549504 - Flags: review?(jmathies)
Attachment #8549504 - Flags: review?(bugs)
Attachment #8549504 - Flags: review?(bugs) → review+
Attachment #8549504 - Flags: review?(jmathies) → review+
Comment on attachment 8549504 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: This is a follow up bug of bug 865561.
[User impact if declined]: Web developers don't want small changes of our DOM event behavior repeatedly. So, uplifting this to 37 make the changes once. 
[Describe test coverage new/current, TBPL]: Bug 865561 was landed in 37 cycle. (about a half of a month ago) And this is adding key mapping which are forgotten in bug 865561.
[Risks and why]: As I said above, Uplifting this makes web developers happy since they don't need to test/check our behavior both 37 and 38 for keydown, keypress and keyup event handling. If we don't uplift this, similar changes occur both in 37 and 38. It's too bad for them and makes key value table in MDN messy.
[String/UUID change made/needed]: Nothing.
Attachment #8549504 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/836b7ff0d7e2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8549504 [details] [diff] [review]
Patch

Aurora+
Attachment #8549504 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
:masayuki. I think the documentation is up-to-date (Thank you for doing it, it is a gory one, but so much useful!)

Can you confirm/infirm it?
Flags: needinfo?(masayuki)
Yeah, I did it.
Flags: needinfo?(masayuki)
You need to log in before you can comment on or make changes to this bug.