Closed
Bug 1122007
Opened 9 years ago
Closed 9 years ago
Get rid of TrustedUIManager
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
Bug 911880 reimplemented the trusted UI but didn't get rid of the currently unused trusted_ui.js
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Updated•9 years ago
|
Summary: Get rid of trusted_ui.js → Get rid of TrustedUIManager
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8549647 -
Flags: review?(alive)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8549647 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27421 Great, thanks!
Attachment #8549647 -
Flags: review?(alive) → review+
|
||
Comment 3•9 years ago
|
||
There's an pre-existing intermittent Gij error with TEST-UNEXPECTED-FAIL | apps/system/test/marionette/trusted_window_test.js | trusted window tests launch/close trusted window .. see https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=1fdd0871c4ca Will this patch address/obsolete this? Would avoid redundant working investigating the failure if its all about to change anyhow.
Flags: needinfo?(ferjmoreno)
|
|
Assignee | |
Comment 4•9 years ago
|
||
No, this patch simply gets rid of unused code. It seems that the test that you mention are already green on try. If that's not the case, file a new bug and needinfo :gduan please. Thanks!
Flags: needinfo?(ferjmoreno)
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/1c23c5281fc803051adc4e0f9492cac2fab2c3c5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•