1122070 - TSan: data race netwerk/cache2/CacheIOThread.cpp:97 DispatchInternal

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Nathan Froyd [:froydnj]]

Attachment: netwerk-cache-dispatch-race.txt

[cribbing from decoder's script, hopefully he won't mind]

The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer).

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1].

If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong

Comment 1

[Michal Novotny [:michal]]

Attachment: fix

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8610291 [details] [diff] [review]
fix

Review of attachment 8610291 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33435f6629bf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33435f6629bf