Closed
Bug 1122079
Opened 10 years ago
Closed 10 years ago
[Music] test: Testing whether it can identify video file and excluding it.
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S9 (3apr)
People
(Reporter: hub, Assigned: hub)
References
Details
Attachments
(1 file)
See for details https://moztrap.mozilla.org/manage/case/8456/
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → hub
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Attachment #8568508 -
Flags: review?(dflanagan)
Comment 2•10 years ago
|
||
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master
This test still needs work: it does not actually verify what it says it does
Attachment #8568508 -
Flags: review?(dflanagan) → review-
Assignee | ||
Comment 3•10 years ago
|
||
I have updated the PR, But I'm looking for a way to check that we are finished loading as to ensure we really went through the file. Stay tuned.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master
I have now addressed all the issue. Including making sure we finished scanning.
Attachment #8568508 -
Flags: review- → review?(dflanagan)
Comment 5•10 years ago
|
||
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master
This turns out to be a hard test to do right. There are still timing issues here, and I'm not satisfied that the test actually proves that the movie is being rejected. (The .ogg file could be rejected and the movie accepted, and the test would still pass)
I've left suggestions on github.
Attachment #8568508 -
Flags: review?(dflanagan) → review-
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master
I have addressed all the suggestions in the PR
Attachment #8568508 -
Flags: review- → review?(dflanagan)
Comment 7•10 years ago
|
||
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master
Looks good!
Attachment #8568508 -
Flags: review?(dflanagan) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f85ba0932153b2b7f69b526fb33c82b5ab7122b0
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•