Closed Bug 1122079 Opened 9 years ago Closed 9 years ago

[Music] test: Testing whether it can identify video file and excluding it.

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S9 (3apr)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file)

Blocks: 1121184
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8568508 - Flags: review?(dflanagan)
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master

This test still needs work: it does not actually verify what it says it does
Attachment #8568508 - Flags: review?(dflanagan) → review-
I have updated the PR, But I'm looking for a way to check that we are finished loading as to ensure we really went through the file. Stay tuned.
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master

I have now addressed all the issue. Including making sure we finished scanning.
Attachment #8568508 - Flags: review- → review?(dflanagan)
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master

This turns out to be a hard test to do right. There are still timing issues here, and I'm not satisfied that the test actually proves that the movie is being rejected. (The .ogg file could be rejected and the movie accepted, and the test would still pass)

I've left suggestions on github.
Attachment #8568508 - Flags: review?(dflanagan) → review-
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master

I have addressed all the suggestions in the PR
Attachment #8568508 - Flags: review- → review?(dflanagan)
Comment on attachment 8568508 [details] [review]
[gaia] hfiguiere:bug1122079-test-video-detection > mozilla-b2g:master

Looks good!
Attachment #8568508 - Flags: review?(dflanagan) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: