Closed
Bug 1122095
Opened 9 years ago
Closed 9 years ago
[Music] test: Navigation: Verify the user is able to navigating back to previous screen from playing a song
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S9 (3apr)
People
(Reporter: hub, Assigned: hub)
References
Details
Attachments
(1 file)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → hub
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8570506 [details] [review] [gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master Rebased to master. Now ready to review. Thanks.
Attachment #8570506 -
Flags: review?(dflanagan)
Comment 3•9 years ago
|
||
Comment on attachment 8570506 [details] [review] [gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master Testing the content of the title bar seems like a nice simple proxy for testing that the entire view changed. Are you confident that it will always happen synchronously when the tap event is delivered? Otherwise I worry that you might have a test that fails intermittently because of timing issues. The r- is because the moztrap test case you cite uses a playlist view to test the back button and you're testing the songs view. If you're automating the moztrap test case, then you should at least include a playlist test as well. It seems like it should be pretty simple to verify that the back button works from the Artists and Albums view as well, and possibly even from their subviews. Can you extend the test to check those things as well?
Attachment #8570506 -
Flags: review?(dflanagan) → review-
Comment 4•9 years ago
|
||
And here's a general question for this and other integration tests: is there a way to tell moztrap that a test is now performed automatically? Or do we just tell QA about that?
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8570506 [details] [review] [gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master I properly wait for things to be present. I also test the back button from various other situations.
Attachment #8570506 -
Flags: review- → review?(dflanagan)
Comment 6•9 years ago
|
||
Comment on attachment 8570506 [details] [review] [gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master This looks great!
Attachment #8570506 -
Flags: review?(dflanagan) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/28519 Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b1cb8041b7014af9c455d0730c3bde8e14006c6c
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•