Closed Bug 1122097 Opened 7 years ago Closed 7 years ago

[Music] test: Test with tracks that have non-ASCII or special characters in title

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file)

Blocks: 1121184
Assignee: nobody → hub
Status: NEW → ASSIGNED
Comment on attachment 8576375 [details] [review]
[gaia] hfiguiere:bug1122097-special-name > mozilla-b2g:master

last one.
Attachment #8576375 - Flags: review?(dflanagan)
Comment on attachment 8576375 [details] [review]
[gaia] hfiguiere:bug1122097-special-name > mozilla-b2g:master

Overall this looks good, but r- because the particular string you chose as the song title can actually be set on innerHTML and come out unchanged in textContent, and I think you want to test with one that would actually be changed when set on innerHTML and read via textContent. See github.
Attachment #8576375 - Flags: review?(dflanagan) → review-
Comment on attachment 8576375 [details] [review]
[gaia] hfiguiere:bug1122097-special-name > mozilla-b2g:master

updated PR.
Attachment #8576375 - Flags: review- → review?(dflanagan)
Comment on attachment 8576375 [details] [review]
[gaia] hfiguiere:bug1122097-special-name > mozilla-b2g:master

looks good now.
Attachment #8576375 - Flags: review?(dflanagan) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.