Closed Bug 1122099 Opened 9 years ago Closed 9 years ago

[Music] test: Playlists: Verify "Shuffle" functionality

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S9 (3apr)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file)

[gaia] hfiguiere:bug1122099-shuffle-playlist > mozilla-b2g:master
46 bytes, text/x-github-pull-request
djf
: review+
Details | Review
Blocks: 1121184
Pitfall: this one is a bit tricky as the order not changing IS a valid case since we have randomness.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8567435 - Flags: review?(dflanagan)
Comment on attachment 8567435 [details] [review]
[gaia] hfiguiere:bug1122099-shuffle-playlist > mozilla-b2g:master

It looks to me like this test is guaranteed to pass even if shuffling is completely broken. See my comments on github.
Attachment #8567435 - Flags: review?(dflanagan) → review-
Comment on attachment 8567435 [details] [review]
[gaia] hfiguiere:bug1122099-shuffle-playlist > mozilla-b2g:master

I think I have addressed the comments.
Attachment #8567435 - Flags: review- → review?(dflanagan)
Comment on attachment 8567435 [details] [review]
[gaia] hfiguiere:bug1122099-shuffle-playlist > mozilla-b2g:master

looks much better now. thanks.
Attachment #8567435 - Flags: review?(dflanagan) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: