1122105 - [Music] test: Actual album art for songs should always be displayed if contained within its metadata

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

See https://moztrap.mozilla.org/manage/case/8749/

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1122105-test-album-cover-display > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 8569943 [details] [review]
[gaia] hfiguiere:bug1122105-test-album-cover-display > mozilla-b2g:master

Another test to review. This one is standalone.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8569943 [details] [review]
[gaia] hfiguiere:bug1122105-test-album-cover-display > mozilla-b2g:master

I left a few comments on github. This test looks pretty good, but I'd like you to extend it so that at a minimum it verifies that a song with album art displays something different than a song without album art. As it stands, you're just verifying that every list item has a blob URL.

Comment 4

[Hubert Figuiere [:hub]]

Comment on attachment 8569943 [details] [review]
[gaia] hfiguiere:bug1122105-test-album-cover-display > mozilla-b2g:master

Re-requesting review after updating the test to take the feedback into account.

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8569943 [details] [review]
[gaia] hfiguiere:bug1122105-test-album-cover-display > mozilla-b2g:master

Thanks for these changes.  

Looks like you accidentally checked in a .jpg file that is not used, so I think you should remove that.

Also, I recommend adding some comments to the test to document the metadata requirements for the test files, since the test will break if the alphabetical order of the album, artist, or titles change, and that seems like it might be a hard thing to figure out and fix.

Comment 6

[Hubert Figuiere [:hub]]

Will remove the .jpg and add a comment. Thanks.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/dbcce5315fc2bca09ee04c34a4743a5ed91a0fe8