Add a link to release notes from admin.cgi

RESOLVED FIXED in Bugzilla 5.0

Status

()

--
minor
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Bugzilla 5.0
Bug Flags:
approval +
approval5.0 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
As part of bug 390955, the release notes link was removed from the home page citing that normal users normally should not care about that information.

We should add the link back to an admin page so that admins can get to it easily. In 5.0, an admin would need to know the exact URL to find them right now.

Not a blocker for 5.0 but should be fixed in a minor revision IMO.

dkl
(Assignee)

Comment 1

4 years ago
Created attachment 8549755 [details] [diff] [review]
1122125_1.patch
Attachment #8549755 - Flags: review?(LpSolit)

Comment 2

4 years ago
Comment on attachment 8549755 [details] [diff] [review]
1122125_1.patch

>+        <dt id="release_notes" class="[% class %]">

It doesn't make sense to mark the link as not clickable if I'm not an admin. Everybody allowed to view this page should be free to access release notes. So we don't need a class here.


>+        <dd class="[% class %]">Detailed information related to this release of B[%%]ugzilla.</dd>

Same here. Moreover, remember that hardcoded "Bugzilla" is allowed in templates. No need for the [%%] hack anymore.
Attachment #8549755 - Flags: review?(LpSolit) → review-

Updated

4 years ago
Summary: Release notes should be linked to from somewhere the admin can see but not necessarily normal users. → Add a link to release notes from admin.cgi
(Assignee)

Comment 3

4 years ago
Created attachment 8549841 [details] [diff] [review]
1122125_2.patch
Attachment #8549755 - Attachment is obsolete: true
Attachment #8549841 - Flags: review?(LpSolit)

Comment 4

4 years ago
Comment on attachment 8549841 [details] [diff] [review]
1122125_2.patch

r=LpSolit
Attachment #8549841 - Flags: review?(LpSolit) → review+

Comment 5

4 years ago
I will let dkl request approval for 5.0 if he wants it there.
Flags: approval?
(Assignee)

Comment 6

4 years ago
Very low impact and to me a minor regression anyway, so why not.
Flags: approval5.0?
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+

Updated

4 years ago
Target Milestone: --- → Bugzilla 5.0
(Assignee)

Comment 7

4 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   8635fca..ac3f8d9  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   a7c55f6..e3e7b71  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 1204862
You need to log in before you can comment on or make changes to this bug.