Closed
Bug 1122172
Opened 9 years ago
Closed 9 years ago
Typo in PerformanceController.getLocalElapsedTime: function is only accessed, not called
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
|
16.79 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
I think we should take this opportunity to remove all of those get methods from the controller, since we have `getCurrentRecording`.
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8549808 [details] [diff] [review] v1 Review of attachment 8549808 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but probably should rebase or wait after bug 1121196 lands as that'll cause some conflict
Attachment #8549808 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/62b1908ad413
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/62b1908ad413
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•