112218 - "checked" on a radio button or checkbox causes "onchange" to fire

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[bart locanthi]

<input type="radio" name="a" onchange="form.submit()" checked="on"/>

spontaneously submits the form.

Comment 1

[Karl Johan Kleist]

Build ID: 2001 11 27 03. Windows 2000.

I sugggest severity CRITICAL for this one. Simply clicking on the URL link above,
caused my Mozilla to suck 100% CPU for a while and finally crash.

Incident ID: TB38579371W

Comment 2

[Boris Zbarsky [:bzbarsky]]

baaad...

Comment 3

[John Keiser (jkeiser)]

Attachment: Slightly Less Dangerous Testcase

Comment 4

[Asa Dotzler [:asa]]

Stack Signature  nsDSURIContentListener::IsPreferred 8bc9802d
Bug ID
Trigger Time 2001-11-27 13:12:18
Email Address [e-mail]
URL visited http://www.aftonbladet.se/
User Comments
Build ID 2001112706
Product ID MozillaTrunk
Platform
Operating System Win32
Module
Trigger Reason Access violation
Stack Trace
nsDSURIContentListener::IsPreferred
[d:\builds\seamonkey\mozilla\docshell\base\nsDSURIContentListener.cpp, line 150]
nsURILoader::ShouldHandleContent
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 672]
nsURILoader::DispatchContent
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 720]
nsDocumentOpenInfo::DispatchContent
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 300]
nsDocumentOpenInfo::OnStartRequest
[d:\builds\seamonkey\mozilla\uriloader\base\nsURILoader.cpp, line 226]
nsHttpChannel::OnStartRequest
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHttpChannel.cpp, line 2271]
nsOnStartRequestEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp, line 126]
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591]
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 524]
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line
1072]
nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 303]
main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1318]
main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1635]
WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1653]
WinMainCRTStartup()
KERNEL32.DLL + 0x192a6 (0x77e992a6) 

Comment 5

[John Keiser (jkeiser)]

*** Bug 115303 has been marked as a duplicate of this bug. ***

Comment 6

[John Keiser (jkeiser)]

Taking.  The underlying problem is, we have always fired onChange when JS sets
the checked attribute.  This just got worse because now content sets the
attribute instead of the frame.

Comment 7

[John Keiser (jkeiser)]

Attachment: Fix

This fix should tide the tree over until I get radio retooled and fix the JS
error.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Um... jkeiser, is that really the file you meant to upload?

Comment 9

[John Keiser (jkeiser)]

Attachment: Real Fix

Oopsy-daisy :)

Comment 10

[John Keiser (jkeiser)]

By the way, I was mistaken in my earlier comment.  radio does *not* yet set
default value from content.  That is one of the two controls that was not
converted.  The error stemmed from my calling content's Reset() instead of
setting it checked in the radio button frame itself.

The more general problem probably already has a bug and will definitely be in
the radio content/presentation fix.

Comment 11

[rods (gone)]

r=rods

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 115412 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Checkbox has the same exact problem (presumable the same patch in CheckboxFrame)

Comment 14

[John Keiser (jkeiser)]

Attachment: Patch With Checkbox

Added checkbox (tested against most recent dup bug)

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 61879 [details] [diff] [review]
Patch With Checkbox

sr=jst. Given that the changes to the checkbox code is the same as the changes
to the radio code I'd say go ahead and check this in.

Rods, please do a post checkin review if this gets checked in before you have a
chance to look at the additional changes.

Comment 16

[bart locanthi]

still broken in 0.9.7.

i neglected to mention in my first report that this was a new behavior with 0.9.6.

Comment 17

[John Keiser (jkeiser)]

Double drat!  Sorry, I didn't check this in.  I will get to it when I get back 
from vacation (3rd or 4th), or if someone else wants to check it in, you may 
always be my guest :)

Comment 18

[DK]

Mozilla 0.9.7 (2001122106) still fires onChange event if default checkbox state
is "checked" !

Comment 19

[John Keiser (jkeiser)]

Setting to P1 so I remember to check this in next Wed. when my Internet access 
(hopefully) arrives.  Again, anyone interested in checking in in the meantime 
may be my guest.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 21

[Boris Zbarsky [:bzbarsky]]

*** Bug 120279 has been marked as a duplicate of this bug. ***