Closed Bug 1122209 Opened 6 years ago Closed 6 years ago

Prefer HasProperty to LookupProperty

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It amounts to the same thing, but [[HasProperty]] is standard. No change in behavior.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Blocks: 1122293
Comment on attachment 8549847 [details] [diff] [review]
Change some uses of LookupProperty to HasProperty

Looks good. You missed another easy one in DoGetElement.
Attachment #8549847 - Flags: review?(efaustbmo) → review?(evilpies)
Attachment #8549847 - Flags: review?(evilpies) → review+
My patch here, as amended for comment 2, flunks a test somewhere. Need to look into it but atm I have some build bustage to see to.
https://hg.mozilla.org/mozilla-central/rev/a2f4d6a4a23b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.