Prefer HasProperty to LookupProperty

RESOLVED FIXED in mozilla38

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
It amounts to the same thing, but [[HasProperty]] is standard. No change in behavior.
(Assignee)

Comment 1

4 years ago
Created attachment 8549847 [details] [diff] [review]
Change some uses of LookupProperty to HasProperty
Attachment #8549847 - Flags: review?(efaustbmo)
(Assignee)

Updated

4 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Blocks: 1122293
Comment on attachment 8549847 [details] [diff] [review]
Change some uses of LookupProperty to HasProperty

Looks good. You missed another easy one in DoGetElement.
Attachment #8549847 - Flags: review?(efaustbmo) → review?(evilpies)
Attachment #8549847 - Flags: review?(evilpies) → review+
(Assignee)

Comment 3

3 years ago
My patch here, as amended for comment 2, flunks a test somewhere. Need to look into it but atm I have some build bustage to see to.
https://hg.mozilla.org/mozilla-central/rev/a2f4d6a4a23b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.