Closed
Bug 1122209
Opened 9 years ago
Closed 9 years ago
Prefer HasProperty to LookupProperty
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.54 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
It amounts to the same thing, but [[HasProperty]] is standard. No change in behavior.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8549847 -
Flags: review?(efaustbmo)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8549847 [details] [diff] [review] Change some uses of LookupProperty to HasProperty Looks good. You missed another easy one in DoGetElement.
Attachment #8549847 -
Flags: review?(efaustbmo) → review?(evilpies)
|
|
||
Updated•9 years ago
|
Attachment #8549847 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
My patch here, as amended for comment 2, flunks a test somewhere. Need to look into it but atm I have some build bustage to see to.
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f4d6a4a23b
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a2f4d6a4a23b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•