1122242 - more MOZ_OVERRIDE in accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: use MOZ_OVERRIDE in accessible/

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8549912 [details] [diff] [review]
use MOZ_OVERRIDE in accessible/

Review of attachment 8549912 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/NotificationController.h
@@ +239,5 @@
>      NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(ContentInsertion)
>      NS_DECL_CYCLE_COLLECTION_NATIVE_CLASS(ContentInsertion)
>  
>      bool InitChildList(nsIContent* aStartChildNode, nsIContent* aEndChildNode);
> +    virtual void Process();

remove virtual

::: accessible/xul/XULFormControlAccessible.h
@@ +174,5 @@
>    XULToolbarButtonAccessible(nsIContent* aContent, DocAccessible* aDoc);
>  
>    // Accessible
>    virtual void GetPositionAndSizeInternal(int32_t *aPosInSet,
> +                                          int32_t *aSetSize) MOZ_OVERRIDE;

you could fix type* name while you're here

::: accessible/xul/XULTreeAccessible.h
@@ +261,5 @@
>  protected:
>  
>    // Accessible
>    virtual Accessible* GetSiblingAtOffset(int32_t aOffset,
> +                                         nsresult *aError = nullptr) const

and here

Comment 3

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8714804a7c65

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8714804a7c65