Closed
Bug 1122242
Opened 10 years ago
Closed 10 years ago
more MOZ_OVERRIDE in accessible/
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(1 file)
51.29 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8549912 -
Flags: review?(surkov.alexander)
Comment 2•10 years ago
|
||
Comment on attachment 8549912 [details] [diff] [review]
use MOZ_OVERRIDE in accessible/
Review of attachment 8549912 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/base/NotificationController.h
@@ +239,5 @@
> NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(ContentInsertion)
> NS_DECL_CYCLE_COLLECTION_NATIVE_CLASS(ContentInsertion)
>
> bool InitChildList(nsIContent* aStartChildNode, nsIContent* aEndChildNode);
> + virtual void Process();
remove virtual
::: accessible/xul/XULFormControlAccessible.h
@@ +174,5 @@
> XULToolbarButtonAccessible(nsIContent* aContent, DocAccessible* aDoc);
>
> // Accessible
> virtual void GetPositionAndSizeInternal(int32_t *aPosInSet,
> + int32_t *aSetSize) MOZ_OVERRIDE;
you could fix type* name while you're here
::: accessible/xul/XULTreeAccessible.h
@@ +261,5 @@
> protected:
>
> // Accessible
> virtual Accessible* GetSiblingAtOffset(int32_t aOffset,
> + nsresult *aError = nullptr) const
and here
Attachment #8549912 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•