Add web activity for language pack

RESOLVED FIXED in 2015-02-17

Status

Marketplace
Consumer Pages
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: andym, Assigned: mat)

Tracking

Avenir
2015-02-17
x86
Mac OS X
Points:
---

Details

(Whiteboard: [qa-])

(Reporter)

Description

3 years ago
Add in a web activity to jump to a language packs display page added in bug 1122256, so that settings or other apps can jump to it.
(Assignee)

Updated

3 years ago
Assignee: nobody → mpillard
(Assignee)

Comment 1

3 years ago
In order not to have to submit a new package, I suggest re-using the marketplace-category activity and implement it there. I've done that in my branch. So to get the langpacks list to appear once it's implemented you'd do: 

new window.MozActivity({
    name: 'marketplace-category',
    data: {
        slug: 'langpacks',
        fxos_version: '2.2'
    }
});
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Fixed in https://github.com/mozilla/fireplace/commit/54c701001e597a5570d95a6cdcd6d09c3102880b (merged in https://github.com/mozilla/fireplace/commit/21345851b7f64ff9bb2a057b14cdaa09e8d7c0ff)


Note: for the moment, no way to navigate back to the settings page exist. We'll discuss whether or not it's an issue to come up with a solution, this is not something that we can easily implement on Marketplace side alone, because of the iframed app constraints.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Priority: P3 → P2
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2015-02-17
(In reply to Mathieu Pillard [:mat] from comment #1)
> In order not to have to submit a new package, I suggest re-using the
> marketplace-category activity and implement it there. I've done that in my
> branch. So to get the langpacks list to appear once it's implemented you'd
> do: 
> 
> new window.MozActivity({
>     name: 'marketplace-category',
>     data: {
>         slug: 'langpacks',
>         fxos_version: '2.2'
>     }
> });

I wasn't CC'ed to this bug which is why I didn't comment earlier.  In an email thread with Wil and David, we agreed to the following activity spec:

  new window.MozActivity({
    name: 'marketplace-langpacks',
    data: {
      version: '2.2'   // major.minor
    }
  });

This is what I implemented in bug 1115798 and what was approved and uplifted to 2.2.  I think I'd prefer to change this on the Marketplace side instead of going through the approval process in Gaia again, if that's not too much work for you.

(In reply to Mathieu Pillard [:mat] from comment #2)
> Note: for the moment, no way to navigate back to the settings page exist.
> We'll discuss whether or not it's an issue to come up with a solution, this
> is not something that we can easily implement on Marketplace side alone,
> because of the iframed app constraints.

Yep, this is a known limitation.  See bug 1107346 comment 10.  In another email thread, Wil suggested using disposition: inline for the activity, but we decided to err on the safe side for now and leave it to the user to go back to the Settings app.
(Assignee)

Comment 4

3 years ago
I wasn't CCed on that thread :(

We can't use a new activity without publishing a new prod package, prompting all existing users to upgrade. We already pushed one recently and would prefer to avoid doing it again so soon.

I chose marketplace-category precisely because that was already available, made sense in the context, and didn't require us to change our existing package.
Is there a release schedule for the Marketplace app package?  I don't mind waiting a little bit for the next scheduled update, if that's what it takes.
(Reporter)

Comment 6

3 years ago
(In reply to Staś Małolepszy :stas from comment #5)
> Is there a release schedule for the Marketplace app package?  I don't mind
> waiting a little bit for the next scheduled update, if that's what it takes.

Apologies that we all missed each other on bugs, my bad.

We don't have a release schedule. The Marketplace is a website because we try to do the whole web app thing. So we push updates to the Marketplace multiple times a week, but there are parts of the Marketplace we can't update on the phone, basically permissions, web activities and offline messages.

If the Marketplace did this change, we'd make a new package, submit it to Gaia and request an uplift. Every user of the Marketplace (the 70% of users who are on 2.2 for example) would then get an update request to update the Marketplace to the latest version.

If the change was in the settings app, it would get submitted to Gaia and request an uplift.

Happy to chat about this more, but I think the impact to our users is less with the settings change.
(Reporter)

Comment 7

3 years ago
(In reply to Andy McKay [:andym] from comment #6)
> Every user of the Marketplace (the 70% of users
> who are on 2.2 for example) 

Sorry, 70% of our users are on 1.1. Too many versions in my head.
You made me so happy for a moment there...
(Reporter)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

3 years ago
We had a video call together and decided that we were going to keep our current implementation of the Web Activity described in comment 1.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
See Also: → bug 1132974
You need to log in before you can comment on or make changes to this bug.