Closed
Bug 1122273
Opened 9 years ago
Closed 9 years ago
Install a lang pack
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2015-02-17
People
(Reporter: andy+bugzilla, Assigned: mat)
References
Details
(Whiteboard: [qa-])
On the page added in bug 1122256 we need to add in the ability to install a language pack by: - calling the appropriate API [citation needed] - ensure that we don't record the install of the language pack - cope with the appropriate callbacks if they exist for the language pack install
Reporter | ||
Updated•9 years ago
|
Summary: Create install API → Install a lang pack
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mpillard
Assignee | ||
Comment 1•9 years ago
|
||
For the record, it needs to be said somewhere: I thought I was clever by generating a minifest from scratch dynamically, without having to read the original manifest from the package, but this is bad idea. The platform will complain with MANIFEST_MISMATCH because it compares manifests (see https://dxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm?from=webapps.jsm#3791 )
Assignee | ||
Comment 2•9 years ago
|
||
API/Backend changes needed to fix comment 1 were merged in https://github.com/mozilla/zamboni/commit/aaeb2b9f3a8c449bb25ebbda9ea9e737c25a9c71
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/a0d06396d6be1aaec196fa18758d78934e5ef37f and https://github.com/mozilla/fireplace/commit/00e82d6aa55726d0e89ce91d7e397787845eb9d9 (merged in https://github.com/mozilla/fireplace/commit/21345851b7f64ff9bb2a057b14cdaa09e8d7c0ff) We re-use apps_buttons.js code to simply call installPackage() with the minifest URL.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Priority: P3 → P2
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2015-02-17
You need to log in
before you can comment on or make changes to this bug.
Description
•