Closed Bug 1122399 Opened 9 years ago Closed 9 years ago

[Stingray][Home] In arrange mode non-focus cards should appear darker for Gecko version < 35

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

In arrange mode, non-focus cards doesn't appear darker with Gecko version < 35. This is because css filter is not supported by previous version of Gecko. We may need to find another implementation.
Severity: blocker → normal
Summary: [Stingray][Home] In arrange mode non-focus cards should appear darker → [Stingray][Home] In arrange mode non-focus cards should appear darker for Gecko version < 35
Hi Rex, still need your help on this, thanks.
Assignee: nobody → rexboy
Flags: needinfo?(rexboy)
Whiteboard: [ft:conndevices]
Attached file patch
A quick fix uses svg filter rather than filter: brightness().

tzu-lin may you help review this trivial patch?
Flags: needinfo?(rexboy)
Attachment #8553025 - Flags: review?(tzhuang)
Comment on attachment 8553025 [details] [review]
patch

Looks good to me, thanks
Attachment #8553025 - Flags: review?(tzhuang) → review+
https://github.com/mozilla-b2g/gaia/commit/3a015d905fd45ddea735019865206a27844b3c0a

thanks Tzu-lin!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: