1122418 - [Stingray] UI-Transition - Intro (Default/Grid views) launch / close transition

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sung Chiu[:sungchiu]]

Home launch transition of default view.

Comment 1

[Sung Chiu[:sungchiu]]

Attachment: Pull Request

1. Add bubbling animation on home screen
2. Add pin card insertion animation

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8557687 [details]
Pull Request

As discussed earlier, may you try mainly the two:
1. Try to move the animation of "insert card" into scrollable.js / animations.js.
2. Try make use of transition-delay in replace of setTimeout, for bubbling animation.

And thanks for your initial work, please try and feel free to ping me for discussing.

Comment 3

[Sung Chiu[:sungchiu]]

(In reply to KM Lee [:rexboy] from comment #2)
> Comment on attachment 8557687 [details]
> Pull Request
> 
> As discussed earlier, may you try mainly the two:
> 1. Try to move the animation of "insert card" into scrollable.js /
> animations.js.
> 2. Try make use of transition-delay in replace of setTimeout, for bubbling
> animation.
> 
> And thanks for your initial work, please try and feel free to ping me for
> discussing.

Thank you, Rex. I have applied your both recommendations, please help me to review again.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8557687 [details]
Pull Request

Please use querySelector and check the strange enlarge and shrink animation while pining something to home.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8557687 [details]
Pull Request

Looks better now, but I need to cancel it since scrollable.insertNodeBefore() would not work correctly itself without calling slide() by current implementation.
It's closer to landing though. Just set review to me again after changing.
Thank you!

Comment 6

[GitHub Autolander Bot]

Attachment: [PullReq] sean2449:Bug_1122418 to mozilla-b2g:master

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8558841 [details] [review]
[PullReq] sean2449:Bug_1122418 to mozilla-b2g:master

Looks good with this version.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8558841 [details] [review]
[PullReq] sean2449:Bug_1122418 to mozilla-b2g:master

Looks overall good to me. I still have some comments on Github, please fix them before landing.

Thanks for your work!

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/f2de8484a9b6d425a06d4d6cc5efb1250ad42ac1
gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=feed96604e3f