Closed Bug 1122423 Opened 9 years ago Closed 9 years ago

[Stingray] UI-Transition - Deck launcher waving effect

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

References

Details

Attachments

(2 files)

Waving effect of pinned home app
Attached file Pull Request
Attachment #8552786 - Flags: review?(rexboy)
Attachment #8552786 - Flags: review?(im)
1. Use css animation property to make waving animation.
2. Front and back waves in all four decks have different left and bottom positions, so I have to create eight different css animations.
3. Add more properties in class Deck.
Comment on attachment 8552786 [details] [review]
Pull Request

Please check my comments at PR. Remove the review flag because:
1. We should not use classList.length to be a condition to send the focus-transitioned event.
2. You had add few options to json file. This file will be moved to shared. So, please sync this with dwi2.
Attachment #8552786 - Flags: review?(im)
Our UI Spec video: https://drive.google.com/file/d/0B2-G3kew1WpXaW15U3RXcmlXd2c/view
The attached demo video is tested on Nexus5 with fps:60
Attachment #8552786 - Flags: review?(rexboy) → review?(im)
Comment on attachment 8552786 [details] [review]
Pull Request

looks good to me.
Attachment #8552786 - Flags: review?(im) → review+
Comment on attachment 8552786 [details] [review]
Pull Request

Rex,

Please review this one. I think it's good to me.
Attachment #8552786 - Flags: review?(rexboy)
Comment on attachment 8552786 [details] [review]
Pull Request

Looks good to me, with some nit mistakes.

Please correct them before landing.

Thanks!
Attachment #8552786 - Flags: review?(rexboy) → review+
1. Merge Request: https://github.com/mozilla-b2g/gaia/commit/958924d5a85053a02a66f3f7ae94f9e4a5f5b88d
2. Gaia Try(all passed): https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=daaf59f48c52
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1129808
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: