Closed Bug 1122426 Opened 8 years ago Closed 8 years ago

[Stingray] UI-Transition - Animation for rename/delete button in edit mode

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rexboy
: review+
johnhu
: review+
Details | Review
Animation when entering/exiting edit mode. Rename and trash icon should go up/down during the transition.
Blocks: 1129808
Attached file Pull Request
1. Add sliding up/down animation for rename/remove buttons in edit mode.
2. Add translate on rename/remove button when their parent card is focused.
3. Remove display none property on card panel since an element can not perform transition when it is hidden on the screen.
Attachment #8561140 - Flags: review?(rexboy)
Attachment #8561140 - Flags: review?(im)
Assignee: nobody → suchiu
Comment on attachment 8561140 [details] [review]
Pull Request

Looks good to me. Please move the css about card-panel to edit.css.
Attachment #8561140 - Flags: review?(im) → review+
Comment on attachment 8561140 [details] [review]
Pull Request

Looks good to me.
Attachment #8561140 - Flags: review?(rexboy) → review+
I forgot to mention in Github.

Please use more specific word to describe your patch rather than "Edit mode enter/exit". It can be read as "animation for enter/exiting edit mode" and that's not what we want.
Summary: [Stingray] UI-Transition - Edit mode enter/exit → [Stingray] UI-Transition - Animation for rename/delete button in edit mode
Blocks: 1131456
You need to log in before you can comment on or make changes to this bug.