1122426 - [Stingray] UI-Transition - Animation for rename/delete button in edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sung Chiu[:sungchiu]]

Animation when entering/exiting edit mode. Rename and trash icon should go up/down during the transition.

Comment 1

[Sung Chiu[:sungchiu]]

Attachment: Pull Request

1. Add sliding up/down animation for rename/remove buttons in edit mode.
2. Add translate on rename/remove button when their parent card is focused.
3. Remove display none property on card panel since an element can not perform transition when it is hidden on the screen.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8561140 [details] [review]
Pull Request

Looks good to me. Please move the css about card-panel to edit.css.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8561140 [details] [review]
Pull Request

Looks good to me.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I forgot to mention in Github.

Please use more specific word to describe your patch rather than "Edit mode enter/exit". It can be read as "animation for enter/exiting edit mode" and that's not what we want.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/3f26c02d828695a3665da2be7ae1229b1715616b
gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=ecf81f09b5a2