112247 - bad JS takes down entire browser

Status: VERIFIED DUPLICATE of bug 110560

(Core :: Networking: Cookies, defect)

Description

[hans_k_97]

Apologies, my Javascript isn't good enough to say exactly what's going on here-
The following javascript crashes the entire browser when the cookie isn't
present.  Even if there's an error, it shouldn't take down the whole program...

function getCookie(name) {
 var cname = name + "=";
 var dc = document.cookie;
 if (dc.length != 0) {
  begin = dc.indexOf(cname);
  if (begin != -1) {
   begin += cname.length;
   end = dc.indexOf(";", begin);
   if (end == -1) end = dc.length;
   return unescape(dc.substring(begin, end));
  }
 }
 return null; 
}
var visitsCookie = getCookie('Visits');

Comment 1

[hans_k_97]

Attachment: WARNING: Crashes browser! Javascript in HTML body (getting cookie)

This JS seems to work fine on the original page, but crashes locally I would
assume because of the missing cookie.

Comment 2

[Karl Johan Kleist]

Reporter: Please always specify the Build ID (as found in the title bar).

Also, a crash should have the severity level "critical".

Thank you.

Comment 3

[Karl Johan Kleist]

Possibly related to Bug 110560 ? Reporter: can you reproduce the crash
using a recent build?

Comment 4

[hans_k_97]

Sorry- crash is with 2001112600, Mandrake Linux 8.1.

Comment 5

[Matthias Versen [:Matti]]

wfm with win2k build 20011127..

This should be a dupe of bug 110560
Reporter: Can you try it with the latest nightly build (20011127) or can you
give us a talkback ID of that crash ?

Comment 6

[Phil Schwartau]

Reassigning to Cookies for parity with suggested dupe.

Comment 7

[Phil Schwartau]

WORKSFORME using Mozilla trunk binaries 2001-11-26-xx Mac9.1,
2001-12-03-xx WinNT, Linux. I can load attachment 59386 [details] just fine;
I do not crash. I also do not crash if I save that HTML and
load it locally. 

Don't know whether to mark this as WORKSFORME or as a duplicate
of bug 110560; the Cookies component will know best. 

[e-mail]: can you try it with the latest nightly build
and see if you still crash? 

Comment 8

[Stephen P. Morse]

I would say this is definitely a dup of bug 110560, especially considering the 
comment "work fine on the original page, but crashes locally".  That was exactly 
what bug 110560 was doing.

Reopen if you are still seeing this with a recent build.

*** This bug has been marked as a duplicate of 110560 ***

Comment 9

[hans_k_97]

yup, WFM.
thanks.

Comment 10

[benc]

VERFIED/dupe