Closed Bug 1122501 Opened 5 years ago Closed 5 years ago

[Messages][Drafts] Unsaved draft is silently discarded when user tries to forward message

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, minor)

ARM
Linux
defect
Not set
minor

Tracking

(b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 affected, b2g-master verified)

RESOLVED FIXED
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- affected
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: azasypkin, Assigned: azasypkin, Mentored)

Details

(Whiteboard: [sms-papercuts][lang=js][mentor-lang=ru])

Attachments

(2 files)

I tested it on v2.0, v2.1, v2.2 and master - so looks like it was always so.

STR:
* Open Messages app and navigate to any active thread;
* Enter some text into message input;
* Long tap on any existing message in the thread and choose "Forward";

Expected result: user should see confirmation dialog that allows him to discard draft and continue or to cancel forwarding; We do it correctly for the case when user tries to send message to a number located inside thread message;

Actual result: unsent message is silently discarded and user automatically proceeds with forwarding;

Please see reply to bug 1116780 comment 7 to know how confirmation dialog should look like.

The patch for this bug should definitely include integration test.
UPDATE: please see bug 1116780 comment 13 for the UX reply on suggested dialog style.
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Comment on attachment 8553809 [details] [review]
GitHub pull request URL

Hey Steve, here is the patch that adds confirmation dialog for "forward" case + makes all such dialogs similar.

Thanks!
Attachment #8553809 - Flags: review?(schung)
Hi Oleg, the patch looks good overall and only one question(not related to forward part) https://github.com/mozilla-b2g/gaia/pull/27638/files#r23747511 Any opinion from your side?
Flags: needinfo?(azasypkin)
(In reply to Steve Chung [:steveck] from comment #4)
> Hi Oleg, the patch looks good overall and only one question(not related to
> forward part) https://github.com/mozilla-b2g/gaia/pull/27638/files#﷒0﷓ Any
> opinion from your side?

Hey Steve, thanks for review and I really like your suggestion! So I addressed it in the separate commit. + one-line fix for old, but related group-email-thread bug I just noticed.
Flags: needinfo?(azasypkin)
Comment on attachment 8553809 [details] [review]
GitHub pull request URL

The patch looks great. Only one thought about the test, so r=me. Thanks!
Attachment #8553809 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck](OOO 2/18 - 2/23) from comment #6)
> Comment on attachment 8553809 [details] [review]
> GitHub pull request URL
> 
> The patch looks great. Only one thought about the test, so r=me. Thanks!

Thanks! Nits fixed and Treeherder is green.

Master: https://github.com/mozilla-b2g/gaia/commit/4f68c48090faee9313c02b28a7fc261c3187162e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attached video verified_v3.0.mp4
This bug has been verified as pass on latest Nightly Flame v3.0 and Nexus5 v3.0,by the STR of Comment 0. 

Actual results:  User can see confirmation dialog that allows him to discard draft and continue or to cancel forwarding

See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

Device: Flame 3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.192042
Firmware Date          Wed Jun  3 19:20:53 EDT 2015
Bootloader             L1TC000118D0


Device: Nexus5 3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.193140
Firmware Date          Wed Jun  3 19:31:59 EDT 2015
Bootloader             HHZ12f
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.