1122553 - BroadcastChannel crashes when a blob is sent to the same page.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: crash.patch

The issue is that, when a blob actor is created by the same Manager who owns it, we have a crash. This patch fixes the issue for the BroadcastChannel API, but maybe we want a more generic solution.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: crash.patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8550549 [details] [diff] [review]
crash.patch

Review of attachment 8550549 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/broadcastchannel/BroadcastChannelParent.cpp
@@ +81,5 @@
>  {
>    AssertIsOnBackgroundThread();
>  
>    if (aOrigin == mOrigin && aChannel == mChannel) {
>      // We need to duplicate data only if we have blobs.

You should update this comment to explain why you're doing the extra stuff

::: dom/broadcastchannel/BroadcastChannelService.cpp
@@ +131,5 @@
>    AssertIsOnBackgroundThread();
>    MOZ_ASSERT(aParent);
>    MOZ_ASSERT(mAgents.Contains(aParent));
>  
> +  nsAutoTArray<nsRefPtr<FileImpl>, 1> files;

You could probably get away with 10 :)

And comment why you're doing this.

You could also move this to the PostMessageData struct...

@@ +138,5 @@
> +
> +    for (uint32_t i = 0, len = aData.blobsParent().Length(); i < len; ++i) {
> +      nsRefPtr<FileImpl> impl =
> +        static_cast<BlobParent*>(aData.blobsParent()[i])->GetBlobImpl();
> +     files.AppendElement(impl);

MOZ_ASSERT(impl)

Comment 3

[Andrea Marchesini [:baku]]

Attachment: crash.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f193083a5f3

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55a6b53cd045

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/55a6b53cd045