UITour-lib.js should be `require()`-able

RESOLVED FIXED in Firefox 38

Status

()

Firefox
Tours
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat ), Assigned: Dexter)

Tracking

37 Branch
Firefox 38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

728 bytes, patch
Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )
: review+
Unfocused
: review+
Details | Diff | Splinter Review
add this line to the end of it :)


```
// added to make this requireable.
if (typeof module !== undefined)  module.exports = Mozilla.UITour;
```

Maybe part of the other tour patches, this is trivial.
(Assignee)

Comment 1

3 years ago
Created attachment 8551409 [details] [diff] [review]
bug1122563.patch

Does this help?
Comment on attachment 8551409 [details] [diff] [review]
bug1122563.patch

Looks fine to me! I don't believe it causes any side effects.
Attachment #8551409 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8551409 - Flags: review?(MattN+bmo)
Comment on attachment 8551409 [details] [diff] [review]
bug1122563.patch

Review of attachment 8551409 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really know anything about that module system but I think Unfocused might. Alessio, are you familiar with it enough to know that this works? If so, I'm fine with it.
Attachment #8551409 - Flags: review?(MattN+bmo) → review?(bmcbride)
Comment on attachment 8551409 [details] [diff] [review]
bug1122563.patch

Review of attachment 8551409 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8551409 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 5

3 years ago
Thanks :Unfocused for the review! I know that is require-able from NodeJS, not familiar enough with RequireJS to give an opinion about that.

Do I need to push to try this or can simply flag it as checkin-needed?
Flags: needinfo?(MattN+bmo)
Don't think this needs a Try run.
Flags: needinfo?(MattN+bmo)
Keywords: checkin-needed
(Assignee)

Comment 7

3 years ago
Thanks for flagging it as checkin-needed!
https://hg.mozilla.org/integration/fx-team/rev/df5c6946b587
Assignee: nobody → alessio.placitelli
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/df5c6946b587
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
https://hg.mozilla.org/mozilla-central/rev/df5c6946b587
You need to log in before you can comment on or make changes to this bug.