112257 - Reply quoting includes header text

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[lohphat]

2001112703 on win2Kpro-sp2

When replying to a message, the quoted text now includes all of the header and
attached vcard data instead of just the body text.

This is an unexpected change of behavior and if it is intentional, there should
be an XP pref to specify the quote format.

Comment 1

[Sheela Ravindran]

confirming this on win98 build: 2001-11-27-06. I see all the header info
including the body while replying.  

Comment 2

[Sheela Ravindran]

JFD,

We did not show any headers when we reply to a message.  There should be a pref
that needs to be put in manually in the pref.js if the user wants it that way. 
This is a changed behavior in today's build.  Nominating this bug. 

Comment 3

[Jean-Francois Ducarroz]

Looking at it...

Comment 4

[Jean-Francois Ducarroz]

This regression has been caused by the fix for bug 110846. We use SetQuery() to
add  "header=quotebody" to the url we pass to mime. Mime retreive the url as a
string using GetSpec(). The problem is that GetSpec does not unescape the url
and therfore the query part looks like "?header%3Dquotebody" which make the mime
code  faild to detect it!

I am not sure if GetSpec is suppos to unescape the url or if I should work
around this new behavior! cc'ing darin for advise.

Comment 5

[Jean-Francois Ducarroz]

I just spoke with darin and it's correct that GetSpec doesn't unescape the url
however it incorrect that the equal sign get encoded. He has the soluion to this
problem. Reassign to him.

Comment 6

[Darin Fisher]

Attachment: v1.0 patch

fixes the typo in nsStandardURL.cpp

Comment 7

[Darin Fisher]

Jean-Francois: can i get a r= on this from you?  thx!

Comment 8

[Scott MacGregor]

Comment on attachment 59437 [details] [diff] [review]
v1.0 patch

sr=mscott

Comment 9

[Gagan]

Comment on attachment 59437 [details] [diff] [review]
v1.0 patch

r=gagan

Comment 10

[Darin Fisher]

fixed-on-trunk

Comment 11

[Jean-Francois Ducarroz]

and reply is working again. Thanks Darin for the quick resolution

Comment 12

[Sheela Ravindran]

verified the header text is not displayed anymore with reply and reply all

2001-11-30-06 win98, mac, linux

Comment 13

[lohphat]

This started again with todays 2001122003 win32 build

Comment 14

[Sheela Ravindran]

Marking this as fixed.
Reporter,
There is already a new bug logged. Please don't reopen the old ones.  Some times
the bugs can reappear due to different regressions.  
See bug 116044

Comment 15

[Sheela Ravindran]

verified so