Closed Bug 1122590 Opened 5 years ago Closed 5 years ago

./mach mochitest cannot run devtools tests

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ehsan, Assigned: ahal)

Details

Attachments

(1 file)

./mach mochitest browser/devtools/inspector/test/browser_inspector_search-01.js does not work.  Using mochitest-devtools works.
Component: mach → Mochitest
Product: Core → Testing
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1098259
Bug 1068676 which is the ultimate but this was marked as duped against never fixed this.  Reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Technically the mach command/harness is actually doing the right thing here. Devtools is a subsuite, not a flavor, which means you need to run with --subsuite devtools for it to pick any devtools tests up, e.g this works:

./mach mochitest browser/devtools --subsuite devtools

But yes, that is a huge UX wart and should obviously be fixed :). The mochitest command should be smart enough to realize that we are trying to run devtools tests and do the right thing.
I have this fixed in the patch posted to bug 1164597. If that bug gets delayed for too long I'll cherry pick the fix here, otherwise we should be able to resolve this when 1164597 lands.
Bug 1164597 is landed on central, so this should now be fixed.
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
It doesn't seem fixed here:

$ mach mochitest browser/devtools/debugger/test/browser_dbg_aaa_run_first_leaktest.js 
/usr/bin/make -j4 -s install-tests
From _tests: Kept 36076 existing; Added/updated 0; Removed 0 files and 0 directories.

######
### Now running mochitest-browser with subsuite devtools.
######

Checking for orphan ssltunnel processes...
Checking for orphan xpcshell processes...
0 ERROR no tests to run using specified combination of filters: skip_if, run_if, fail_if, remove_imptest_failure_expectations, subsuite(name=None)
SUITE-START | Running 0 tests
1 ERROR no tests to run using specified combination of filters: skip_if, run_if, fail_if, remove_imptest_failure_expectations, subsuite(name=None)
TEST-INFO | checking window state
Browser Chrome Test Summary
	Passed: 0
	Failed: 0
	Todo: 0
*** End BrowserChrome Test Results ***
SUITE-END | took 0s
$ mach mochitest --subsuite devtools browser/devtools/debugger/test/browser_dbg_aaa_run_first_leaktest.js 
/usr/bin/make -j4 -s install-tests
From _tests: Kept 36076 existing; Added/updated 0; Removed 0 files and 0 directories.

######
### Now running mochitest-browser with subsuite devtools.
######

Checking for orphan ssltunnel processes...
Checking for orphan xpcshell processes...
SUITE-START | Running 1 tests

[... works fine ...]]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Crap, this was working, but then I accidentally broke it again while addressing an innocuous looking review nit.
Bug 1122590 - Make |mach mochitest| properly detect devtools tests (and other subsuites), r=chmanchester
Attachment #8614077 - Flags: review?(cmanchester)
Assignee: nobody → ahalberstadt
Status: REOPENED → ASSIGNED
Comment on attachment 8614077 [details]
MozReview Request: Bug 1122590 - Make |mach mochitest| properly detect devtools tests (and other subsuites), r=chmanchester

https://reviewboard.mozilla.org/r/9855/#review8703

Ship It!
Attachment #8614077 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/b81fb2621422
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.