Cleanup the signing code on olympia

RESOLVED FIXED in 2015-02

Status

addons.mozilla.org Graveyard
Code Quality
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: magopian, Assigned: magopian)

Tracking

unspecified
2015-02
x86
Mac OS X

Details

(Whiteboard: [qa-])

(Assignee)

Description

3 years ago
The signing code for olympia was mainly copied over from zamboni. However, the needs are rather different, so some cleanup would be useful to get rid of unused code:

- remove the SIGNING_REVIEWER* settings and the associated tests
- remove lib/crypto/receipt.py file (and associated tests)
- remove "mock_sign" in lib/crypto/tests.py
- move "addon.sign_version_files" to "version.sign_files"
- change exception messages from "posting to app signing" to "posting to addon signing"
- get rid of "resign": we always resign
- get rid of the SIGNING_OMIT_PER_FILE_SIGS setting that isn't used
- get rid of "ids" in packaged.py
(Assignee)

Comment 2

3 years ago
Fixed in https://github.com/mozilla/olympia/commit/07c821d5dba5044fd8d6c4f4ac4e6835c450ecc9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.