1122634 - Lazy load the xul-app.jsm in toolkit/loader

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Since compatibility checking is opt-in the toolkit/loader module may never need the sdk/system/xul-app.jsm file, in which case loading it is unnecessary (ex devtools loader) and could affect startup time.   Therefore I think we should lazy load this jsm module.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1833

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Trying this:

remote: You can view your change at the following URL:
remote:   https://hg.mozilla.org/try/rev/028f7db0bd49
remote: You can view the progress of your build at the following URL:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=028f7db0bd49
remote: Alternatively, view them on TBPL (soon to be deprecated):
remote:   https://tbpl.mozilla.org/?tree=Try&rev=028f7db0bd49

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #2)
> Trying this:
> 
> remote: You can view your change at the following URL:
> remote:   https://hg.mozilla.org/try/rev/028f7db0bd49
> remote: You can view the progress of your build at the following URL:
> remote:  
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=028f7db0bd49
> remote: Alternatively, view them on TBPL (soon to be deprecated):
> remote:   https://tbpl.mozilla.org/?tree=Try&rev=028f7db0bd49

Oops I missed one change to the moz.build that needed to happen:

remote: You can view your change at the following URL:
remote:   https://hg.mozilla.org/try/rev/9d05af3e48d8
remote: You can view the progress of your build at the following URL:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d05af3e48d8
remote: Alternatively, view them on TBPL (soon to be deprecated):
remote:   https://tbpl.mozilla.org/?tree=Try&rev=9d05af3e48d8

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7a04488ab137a34dc70510581cdaec8b8fa2ed81
Bug 1122634 - Lazy load the xul-app.jsm in toolkit/loader

https://github.com/mozilla/addon-sdk/commit/06394b38974bd96e4e54e5001a8e90783ce67dfe
Merge pull request #1833 from erikvold/1122634

Bug 1122634 - Lazy load the xul-app.jsm in toolkit/loader r=jsantell