Closed
Bug 1122678
Opened 9 years ago
Closed 9 years ago
HTMLMediaElement::SetMozSrcObject does not handle nullptr correctly
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
derf
:
review+
|
Details | Diff | Splinter Review |
Binding code (specifically, |set_mozSrcObject| in HTMLMediaElementBinding.cpp) can pass nullptr to |HTMLMediaElement::SetMozSrcObject|, but this function converts the nullptr to a reference.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → docfaraday
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8550439 [details] [diff] [review] Fix behavior of SetMozSrcObject when passed a nullptr Review of attachment 8550439 [details] [diff] [review]: ----------------------------------------------------------------- try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d325dbabf1ec
Attachment #8550439 -
Flags: review?(roc)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8550439 -
Flags: review?(roc) → review?(tterribe)
|
||
Updated•9 years ago
|
Attachment #8550439 -
Flags: review?(tterribe) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bafb17acfd5c
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bafb17acfd5c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•