Profiler deadlock with pthread_get_stackaddr_np (sampler thread) vs _pthread_find_thread (paused Compositor thread)

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mstange, Assigned: BenWa)

Tracking

Trunk
mozilla43
All
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8550490 [details]
sample

I just got this deadlock while running Talos ts_paint with profiling locally.

Benoit knows how to fix it. (Move the call to pthread_get_stackaddr_np to before thread pausing)
(Assignee)

Comment 1

3 years ago
Created attachment 8652593 [details]
MozReview Request: Bug 1122721 - Don't call pthread_get_stackaddr_np during sampling. r=mstange

Bug 1122721 - Don't call pthread_get_stackaddr_np during sampling. r=mstange
Attachment #8652593 - Flags: review?(mstange)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8652593 [details]
MozReview Request: Bug 1122721 - Don't call pthread_get_stackaddr_np during sampling. r=mstange

https://reviewboard.mozilla.org/r/17211/#review15421

Ship It!
Attachment #8652593 - Flags: review?(mstange) → review+
(Assignee)

Comment 4

3 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ae162714d58ed02870abe32b606926bb349a71d0
changeset:  ae162714d58ed02870abe32b606926bb349a71d0
user:       Benoit Girard <b56girard@gmail.com>
date:       Tue Aug 25 18:03:32 2015 -0400
description:
Bug 1122721 - Don't call pthread_get_stackaddr_np during sampling. r=mstange
https://hg.mozilla.org/mozilla-central/rev/ae162714d58e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.